Re: scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input

Re: scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input

[Eli Zaretskii]

> branch: scratch/tty-child-frames
> commit f62d70f52f4f6b7ed158d618bf790df21f171172
> Author: Gerd Möllmann <gerd@gnu.org>
> Commit: Gerd Möllmann <gerd@gnu.org>
> 
>     Don't pause display for pending input
>     
>     * src/dispnew.c: Remove display_completed, redisplay_dont_pause,
>     redisplay-dont-pause was declared obsolete in Emacs 24.  Remove anything
>     checking pending input, change function signatures accordingly, and so
>     on.
>     
>     * src/keyboard.c (read_char): Don't use redisplay_dont_pause.
>     * src/minibuf.c (read_minibuf): Use new function signatures.
>     * src/xdisp.c: Don't check display_completed. Use new API.
>     
>     * lisp/subr.el (redisplay-dont-pause): Remove declaration.

I don't think this kind of change is appropriate.  Feature branches
should not add/remove features not directly related to the feature
being developed on the branch.  If we want to remove
redisplay-dont-pause from Emacs (and I'm not yet sure we do), it
should be discussed on emacs-devel or in a dedicated bug report, not
silently installed on the branch.

So I think this changeset should be reverted from the branch.  If you
found that this variable somehow adversely affects child frames on
tty, let's discuss what you found and the possible solutions.

Thanks.

Re: scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input

[Gerd Möllmann]

Eli Zaretskii <eliz@gnu.org> writes:

>> branch: scratch/tty-child-frames
>> commit f62d70f52f4f6b7ed158d618bf790df21f171172
>> Author: Gerd Möllmann <gerd@gnu.org>
>> Commit: Gerd Möllmann <gerd@gnu.org>
>> 
>>     Don't pause display for pending input
>>     
>>     * src/dispnew.c: Remove display_completed, redisplay_dont_pause,
>>     redisplay-dont-pause was declared obsolete in Emacs 24.  Remove anything
>>     checking pending input, change function signatures accordingly, and so
>>     on.
>>     
>>     * src/keyboard.c (read_char): Don't use redisplay_dont_pause.
>>     * src/minibuf.c (read_minibuf): Use new function signatures.
>>     * src/xdisp.c: Don't check display_completed. Use new API.
>>     
>>     * lisp/subr.el (redisplay-dont-pause): Remove declaration.
>
> I don't think this kind of change is appropriate.  Feature branches
> should not add/remove features not directly related to the feature
> being developed on the branch.  If we want to remove
> redisplay-dont-pause from Emacs (and I'm not yet sure we do), it
> should be discussed on emacs-devel or in a dedicated bug report, not
> silently installed on the branch.

The variable redisplay-dont-pause is declared obsolete since 24.3 or so.
I wouldn't have expected that removing requires yet another discussion.

>
> So I think this changeset should be reverted from the branch.  If you
> found that this variable somehow adversely affects child frames on
> tty, let's discuss what you found and the possible solutions.
>
> Thanks.

I'll revert that on savannah, but I must add that I don't have the
energy/resources to do complicated ports of stuff from my fork to GNU,
and that's making things definitely more complicated.