From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input Date: Sat, 16 Nov 2024 13:54:08 +0200 Message-ID: <86mshzgzrz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gerd =?iso-8859-1?Q?M=F6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 16 12:55:15 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCHOU-0001oL-OL for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Nov 2024 12:55:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCHNV-000739-UF; Sat, 16 Nov 2024 06:54:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCHNU-00072k-4C for emacs-devel@gnu.org; Sat, 16 Nov 2024 06:54:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCHNT-0001cI-Ru; Sat, 16 Nov 2024 06:54:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:To:From:Date:in-reply-to: references; bh=eVRM+X+c96rxlsxRIUMIDyptvshwzCsCMOxJUPrUze8=; b=b7TsYELwmPD2x6 rDYngYTqM/DyUT6m0o9pBVZc7QDOGo/R18oOUNBaT2ynHzks7gs4MnDh/1uTqTsl6zuRkHMK8UOya GvZXk8KcZroFfZHwyhCzne09E1PgIRfYChlXny2MBf61hSmZutKdtwGfSXDoI4UifMjOkmDvWm4pS kUeIfT0BeAuOmk27i9gbrUoWC5jJ67j57AqP6/RnLJnwgRWPftin0WoSLvq/wyRFKeZyTOPoWIsOG orT3/+XQ0hrY+nJ+YYz95LnubA0+jqa3Wmw93yQNcGuuMO8tsp+dbe/gPeQDbI9KNWMPK67Vnal+Q doUbWsI+R1gSdrPmeM/w==; X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325475 Archived-At: > branch: scratch/tty-child-frames > commit f62d70f52f4f6b7ed158d618bf790df21f171172 > Author: Gerd Möllmann > Commit: Gerd Möllmann > > Don't pause display for pending input > > * src/dispnew.c: Remove display_completed, redisplay_dont_pause, > redisplay-dont-pause was declared obsolete in Emacs 24. Remove anything > checking pending input, change function signatures accordingly, and so > on. > > * src/keyboard.c (read_char): Don't use redisplay_dont_pause. > * src/minibuf.c (read_minibuf): Use new function signatures. > * src/xdisp.c: Don't check display_completed. Use new API. > > * lisp/subr.el (redisplay-dont-pause): Remove declaration. I don't think this kind of change is appropriate. Feature branches should not add/remove features not directly related to the feature being developed on the branch. If we want to remove redisplay-dont-pause from Emacs (and I'm not yet sure we do), it should be discussed on emacs-devel or in a dedicated bug report, not silently installed on the branch. So I think this changeset should be reverted from the branch. If you found that this variable somehow adversely affects child frames on tty, let's discuss what you found and the possible solutions. Thanks.