unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input
Date: Sat, 16 Nov 2024 13:54:08 +0200	[thread overview]
Message-ID: <86mshzgzrz.fsf@gnu.org> (raw)

> branch: scratch/tty-child-frames
> commit f62d70f52f4f6b7ed158d618bf790df21f171172
> Author: Gerd Möllmann <gerd@gnu.org>
> Commit: Gerd Möllmann <gerd@gnu.org>
> 
>     Don't pause display for pending input
>     
>     * src/dispnew.c: Remove display_completed, redisplay_dont_pause,
>     redisplay-dont-pause was declared obsolete in Emacs 24.  Remove anything
>     checking pending input, change function signatures accordingly, and so
>     on.
>     
>     * src/keyboard.c (read_char): Don't use redisplay_dont_pause.
>     * src/minibuf.c (read_minibuf): Use new function signatures.
>     * src/xdisp.c: Don't check display_completed. Use new API.
>     
>     * lisp/subr.el (redisplay-dont-pause): Remove declaration.

I don't think this kind of change is appropriate.  Feature branches
should not add/remove features not directly related to the feature
being developed on the branch.  If we want to remove
redisplay-dont-pause from Emacs (and I'm not yet sure we do), it
should be discussed on emacs-devel or in a dedicated bug report, not
silently installed on the branch.

So I think this changeset should be reverted from the branch.  If you
found that this variable somehow adversely affects child frames on
tty, let's discuss what you found and the possible solutions.

Thanks.



             reply	other threads:[~2024-11-16 11:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-16 11:54 Eli Zaretskii [this message]
2024-11-16 12:50 ` scratch/tty-child-frames f62d70f52f4: Don't pause display for pending input Gerd Möllmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86mshzgzrz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gerd.moellmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).