From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: scratch/fontify-open-string. [Was: CC Mode and electric-pair "problem".] Date: Sun, 15 Jul 2018 04:00:23 -0500 Message-ID: <86lgacswk8.fsf@stephe-leake.org> References: <20180618154227.GB3973@ACM> <20180619050244.GA3946@ACM> <20180627182717.GA4625@ACM> <20180630190327.GC6816@ACM> <83tvpkkr93.fsf@gnu.org> <20180630201447.GE6816@ACM> <83o9frkmk7.fsf@gnu.org> <20180701163825.GC4697@ACM> <86bmbiceq7.fsf@stephe-leake.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531645125 25306 195.159.176.226 (15 Jul 2018 08:58:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Jul 2018 08:58:45 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 15 10:58:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fecrZ-0006Tn-0b for ged-emacs-devel@m.gmane.org; Sun, 15 Jul 2018 10:58:41 +0200 Original-Received: from localhost ([::1]:44882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fectg-0006nQ-1d for ged-emacs-devel@m.gmane.org; Sun, 15 Jul 2018 05:00:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fectY-0006nK-MZ for emacs-devel@gnu.org; Sun, 15 Jul 2018 05:00:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fectU-0002wm-Qh for emacs-devel@gnu.org; Sun, 15 Jul 2018 05:00:44 -0400 Original-Received: from smtp89.ord1d.emailsrvr.com ([184.106.54.89]:45177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fectU-0002n3-M5 for emacs-devel@gnu.org; Sun, 15 Jul 2018 05:00:40 -0400 Original-Received: from smtp4.relay.ord1d.emailsrvr.com (localhost [127.0.0.1]) by smtp4.relay.ord1d.emailsrvr.com (SMTP Server) with ESMTP id 2C7EE400EF for ; Sun, 15 Jul 2018 05:00:25 -0400 (EDT) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp4.relay.ord1d.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id E6739400D0 for ; Sun, 15 Jul 2018 05:00:24 -0400 (EDT) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 (76-218-37-33.lightspeed.kscymo.sbcglobal.net [76.218.37.33]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Sun, 15 Jul 2018 05:00:25 -0400 In-Reply-To: <86bmbiceq7.fsf@stephe-leake.org> (Stephen Leake's message of "Sun, 08 Jul 2018 03:29:36 -0500") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 184.106.54.89 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227422 Archived-At: An update on this; I just had several missing quotes in a buffer, due to a copy/multiple paste that had a quote error. I did lots of editing with the quote errors present. I didn't even notice them until the compiler complained, just like any other syntax error. In my opinion, that is far preferable to the previous behavior of fontifying large parts of the buffer as string, which forced me to pay attention to a trivial syntax error instead of what I was actually doing. This is in Ada, that does not have the option of escaping a newline to create a multiline string, so treating a newline as string terminator is always correct. Anything I can do to help merge this to main? Stephen Leake writes: > Alan Mackenzie writes: > >> It's no longer a matter of assumption. Earlier on this afternoon, I >> committed a preliminary working version of this change to the branch >> scratch/fontify-open-string. > > I've just tried this in ada-mode, and it works nicely. I like the red > face on an unbalanced string quote. > > No noticeable slowdown in anything I've tried so far. > > Let me know if there's some experiment you'd like me to run. -- -- Stephe