From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Thu, 09 Aug 2018 01:07:45 +0100 Message-ID: <86lg9gl7vy.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> <87zhxwig5k.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533773197 17910 195.159.176.226 (9 Aug 2018 00:06:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 00:06:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 02:06:33 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnYTG-0004V2-MO for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 02:06:30 +0200 Original-Received: from localhost ([::1]:45978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnYVL-0003LH-9U for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2018 20:08:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnYUh-0003L9-Py for emacs-devel@gnu.org; Wed, 08 Aug 2018 20:08:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnYUe-0005Ww-K5 for emacs-devel@gnu.org; Wed, 08 Aug 2018 20:07:59 -0400 Original-Received: from [195.159.176.226] (port=47271 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnYUe-0005W5-CI for emacs-devel@gnu.org; Wed, 08 Aug 2018 20:07:56 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fnYSV-0003hv-Iw for emacs-devel@gnu.org; Thu, 09 Aug 2018 02:05:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:LLi7+zg/4Rg/8z/yyII4IRnpBl8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228318 Archived-At: On Wed 08 Aug 2018, Tom Tromey wrote: >>>>>> "Andy" == Andy Moreton writes: > > Andy> Have you run "make check" on the bignum branch ? > > I did this and fixed the problems I saw. > > Andy> 1) A crash in the json tests > Andy> This is bug#32381, fixed on master in commit 3eac378c96. > > I didn't see this, but since it is unrelated to the branch, I wouldn't > have anyway. Tis only happens if you configure with --with-json to use the jansson library for JSON parsing. > Andy> 2) An eassert in make_bignum_str called from string_to_number. > Andy> This appears to be caused by differences in the syntax accepted by > Andy> emacs lisp and by mpz_set_str. To reproduce: > ELISP> (format "+%S" (- most-negative-fixnum)) > Andy> "+2305843009213693952" > ELISP> (string-to-number "+2305843009213693952") > Andy> ### crash ### > > I fixed this. Thanks - retesting on Windows mingw64 x86_64 shows this is fixed. > Andy> 3) Another crash which I have not yet had time to analyse with gdb. This crashes in data-tests-logcount from test/src/data-tests.el, so there is a problem in logcount. > I didn't see this. However, emacs-module-tests.el had a test failure; > I've updated the test. > > I've pushed all the patches I have. Once the logcount problem is fixed, this is looking ready to merge. AndyM