From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Tue, 04 Sep 2018 20:50:49 +0100 Message-ID: <86lg8hf3dy.fsf@gmail.com> References: <83tvn5xicp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536091511 21849 195.159.176.226 (4 Sep 2018 20:05:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 20:05:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 22:05:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxHZS-0005YH-TN for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 22:05:07 +0200 Original-Received: from localhost ([::1]:52460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHbZ-0004K9-3a for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 16:07:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHa2-0003QB-QH for emacs-devel@gnu.org; Tue, 04 Sep 2018 16:05:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxHLm-0000B1-EK for emacs-devel@gnu.org; Tue, 04 Sep 2018 15:51:01 -0400 Original-Received: from [195.159.176.226] (port=49638 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxHLm-0000Ab-7R for emacs-devel@gnu.org; Tue, 04 Sep 2018 15:50:58 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fxHJd-0005Y2-PZ for emacs-devel@gnu.org; Tue, 04 Sep 2018 21:48:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:Cwn6Fxr7PT+wWTxTXQdjcUTqd78= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229261 Archived-At: On Tue 04 Sep 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Tue, 04 Sep 2018 18:37:39 +0100 >> >> As this patch moves init of bignum allocators later in startup, will >> this cause future problems if bignums are used early in emacs before >> dumping ? > > Yes. Ideally, bignums shouldn't be used at dump time at all, but if > we must, they should be used only after the call to init_bignum. Tom added support in commit fb26c9fd69 ("Make purecopy work for bignums"), so if that causes problems then it may need to be revisited. AndyM