From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Speed up project-kill-buffers Date: Thu, 20 May 2021 05:16:46 -0700 Message-ID: <86lf89zjkh.fsf@stephe-leake.org> References: <87mttcgnke.fsf@posteo.net> <871raoezl0.fsf@posteo.net> <86r1ihig9p.fsf@stephe-leake.org> <25bc7f1c-92e5-6b13-a6a4-d48b64b32ad3@yandex.ru> <86im3i76xa.fsf@stephe-leake.org> <86pmxmz45m.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) Cc: Philip Kaludercic , Stefan Monnier , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 20 14:18:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljhcx-0007II-LL for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 14:18:12 +0200 Original-Received: from localhost ([::1]:52536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljhcv-0003I9-Qc for ged-emacs-devel@m.gmane-mx.org; Thu, 20 May 2021 08:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljhbl-0002SJ-6Y for emacs-devel@gnu.org; Thu, 20 May 2021 08:16:58 -0400 Original-Received: from gateway36.websitewelcome.com ([192.185.200.11]:23891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljhbi-00037X-0X for emacs-devel@gnu.org; Thu, 20 May 2021 08:16:55 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 0735C400DA167 for ; Thu, 20 May 2021 07:16:52 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id jhbflGIXvFRe9jhbflDx7C; Thu, 20 May 2021 07:16:52 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ke8KGFuFwY/t+vh+kVZEMAHVZzbb7Csg9+YTxYIztwU=; b=hFIZuZ6Q/6Sbud+wJqX1IlZVQg RvSFoekiHXjzJvuRPvSZ1bvp3GMU2N6gF+rT26GC9kxN0a90Vhki9LMK1IZWE0cs1WRSY0+ZsZxJ2 Cow6SnSbbWT6HVyTS/UNXQ1y8w7+W8BorlFBON0qwslm7+/wSPDkXx9yaEz1Z8qcTlu9CmjZsCx/M QIkq4WSFL4203QDSZ9197ridg/vKelxhlPHjThlRuAL0IrQG4llODZGAjRgPe08a7LMN7KVlYwY+3 aXB/TGhlctCcP/S/Jn3Wbgjf9j33Y3O2plehC4AyR7e7h8hYf3DL/KyMGT11JkgrUoTwLQ8sI0miP B/RIN5KA==; Original-Received: from [76.77.182.20] (port=49647 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ljhbf-0015I0-74; Thu, 20 May 2021 06:16:51 -0600 In-Reply-To: <86pmxmz45m.fsf@stephe-leake.org> (Stephen Leake's message of "Wed, 19 May 2021 16:37:25 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1ljhbf-0015I0-74 X-Source-Sender: (Takver4) [76.77.182.20]:49647 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 4 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: neutral client-ip=192.185.200.11; envelope-from=stephen_leake@stephe-leake.org; helo=gateway36.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269495 Archived-At: Stephen Leake writes: > Hmm. I just found project-kill-buffer-conditions; maybe I could > customize that; it allows arbitrary predicate functions. It would be > more efficient if the predicate function were also passed the project > object, so it doesn't have to call project-current again (hmm - shades > of project-delete-this-buffer-p :). This works for wisi projects, but not for the elisp project (it signals an error): (defun wisi-prj-kill-buffer-condition (buffer) "Return non-nil if BUFFER should be killed. For `project-kill-buffer-conditions'." (let* ((source-path (wisi-prj-source-path (project-current))) (buf-file-name (buffer-file-name buffer)) (done (not (buffer-file-name buffer))) (result nil) dir) (while (and source-path (not done)) (setq dir (pop source-path)) (when (and dir (file-in-directory-p buf-file-name dir)) (setq done t) (setq result t))) result)) (setq project-kill-buffer-conditions (list #'wisi-prj-kill-buffer-condition)) I'm not clear how to set project-kill-buffer-conditions on a per-project basis; it would be simple if this was a cl-defgeneric dispatching on the project. -- -- Stephe