From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Speed up project-kill-buffers Date: Sun, 30 May 2021 10:19:07 -0700 Message-ID: <86lf7wi1h0.fsf@stephe-leake.org> References: <87mttcgnke.fsf@posteo.net> <871raoezl0.fsf@posteo.net> <86r1ihig9p.fsf@stephe-leake.org> <25bc7f1c-92e5-6b13-a6a4-d48b64b32ad3@yandex.ru> <86im3i76xa.fsf@stephe-leake.org> <86pmxmz45m.fsf@stephe-leake.org> <86lf89zjkh.fsf@stephe-leake.org> <07c39e36-83f6-b139-68d5-5b3fc68217bd@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40176"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 30 19:21:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnP7z-000AEu-Ee for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 19:21:31 +0200 Original-Received: from localhost ([::1]:37466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnP7y-0008Rp-3F for ged-emacs-devel@m.gmane-mx.org; Sun, 30 May 2021 13:21:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnP5p-000656-GK for emacs-devel@gnu.org; Sun, 30 May 2021 13:19:17 -0400 Original-Received: from gateway36.websitewelcome.com ([192.185.184.18]:47316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnP5m-0000wZ-3N for emacs-devel@gnu.org; Sun, 30 May 2021 13:19:16 -0400 Original-Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 3710E400D0034 for ; Sun, 30 May 2021 12:19:10 -0500 (CDT) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id nP5hlvFTkAEP6nP5ilQaQe; Sun, 30 May 2021 12:19:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aT0S2HHTDiJRNLHxtdoYZlobc0D46LRtjvzG6coWV3g=; b=cBY/ur8SCfUnSs21qmsEQ6BrWY SMtRhvlQqKSj7X7a+oREUzoUX2MtZLCPwN8j2tKjCokLiBeJ8dzwzJCmkFLBEcflahKwpfQnCQGKa /O1QzevvaXfc4VR9YkVp4wy5P7750ZivBfO3C2j4cXFbfQa6uraeeZTPcNLgsk0MIA7lEyYcXO24y qx4NtCEGVoY9agaZocd9pKVgBtlPaAZ6hxD573WBm/skIMK/fEpSTQPpl5qsz48n+GOCNcyTwQPst FTO2yScQNs8hP/CP6ncg4hbxwHWKzMUM1FJwNQRjFQM+zjfhSOQZ341eklc+djUT2VwBeS/1CNBK6 Bh1h4WmA==; Original-Received: from [76.77.182.20] (port=63448 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lnP5h-003JBI-IP for emacs-devel@gnu.org; Sun, 30 May 2021 11:19:09 -0600 In-Reply-To: <07c39e36-83f6-b139-68d5-5b3fc68217bd@yandex.ru> (Dmitry Gutov's message of "Tue, 25 May 2021 04:30:57 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1lnP5h-003JBI-IP X-Source-Sender: (Takver4) [76.77.182.20]:63448 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: neutral client-ip=192.185.184.18; envelope-from=stephen_leake@stephe-leake.org; helo=gateway36.websitewelcome.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270139 Archived-At: Dmitry Gutov writes: > On 20.05.2021 15:16, Stephen Leake wrote: >> Stephen Leake writes: >> >>> Hmm. I just found project-kill-buffer-conditions; maybe I could >>> customize that; it allows arbitrary predicate functions. It would be >>> more efficient if the predicate function were also passed the project >>> object, so it doesn't have to call project-current again (hmm - shades >>> of project-delete-this-buffer-p :). >> This works for wisi projects, but not for the elisp project (it >> signals >> an error): > > I suppose if you set project-find-functions to a local value in > emacs-lisp-mode buffers (which is IMO unusual), you could also set > project-kill-buffer-conditions to a different local value in those > buffers? yes, that would work. >> (defun wisi-prj-kill-buffer-condition (buffer) >> "Return non-nil if BUFFER should be killed. >> For `project-kill-buffer-conditions'." >> (let* ((source-path (wisi-prj-source-path (project-current))) > > Are those just project sources or dependency dirs as well? Both; it has never been useful to try to make a distinction. -- -- Stephe