From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Thu, 06 Jan 2022 21:52:50 +0200 Organization: LINKOV.NET Message-ID: <86lezs4pmt.fsf@mail.linkov.net> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> <3499cedf-b170-3045-873d-d45d2972ae13@gmx.at> <0f492ac4-4167-5448-2c74-a5f67950eae4@yandex.ru> <2de2323b-6d34-9263-776b-dbeff036f8f4@gmx.at> <87zgog68ni.fsf@gnus.org> <8dfc6f22-d331-e7c1-b536-2d374197528f@gmx.at> <86v8z26o15.fsf@mail.linkov.net> <9d5f512f-dd10-fb6b-2fe7-db24ed92f7c8@gmx.at> <86y23xuv8g.fsf@mail.linkov.net> <867dbgtuls.fsf@mail.linkov.net> <7402a9b1-91cf-a14e-32dc-e9a0cd27dd82@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , Dmitry Gutov , Eli Zaretskii , sdsg@amazon.com, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 06 21:12:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n5Z7C-0006nx-De for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 21:12:02 +0100 Original-Received: from localhost ([::1]:41500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Z7B-0001wk-8L for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jan 2022 15:12:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Z5w-0000JA-Hv for emacs-devel@gnu.org; Thu, 06 Jan 2022 15:10:45 -0500 Original-Received: from [2001:4b98:dc4:8::230] (port=52537 helo=relay10.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Z5u-0006YN-3O for emacs-devel@gnu.org; Thu, 06 Jan 2022 15:10:43 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 81C7B24000B; Thu, 6 Jan 2022 20:10:35 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Thu, 6 Jan 2022 16:30:57 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::230 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284342 Archived-At: >> IIRC I once used the term 'label' for it. It vanished soon. > > After trying to implement this idea I immediately started to dislike it > for technical reasons ('pop-to-buffer-same-window' never had an ACTION > argument so I had to invent some clumsy extra argument to make things > work). I attach the diffs in case we still want to implement something > the like. So in addition to (pop-to-buffer "*shell*" '(nil . ((label . *shell*)))) it will also allow (pop-to-buffer "*shell*" nil nil '*shell*) and (pop-to-buffer-same-window "*shell*" nil '*shell*) ? > Otherwise, I think that harm has been done - 'pop-to-buffer-same-window' > was invented as stand-in for 'switch-to-buffer' and should never have > replaced 'pop-to-buffer' - but I missed that back then so I'm not in a > good position to ask for reverting that change now. Indeed, it's just (defun pop-to-buffer-same-window (buffer &optional norecord) (pop-to-buffer buffer display-buffer--same-window-action norecord)) > Sam's patch, although it does not restore the previous behavior, still > looks like the least obtrusive solution in this regard. It's partially > a misnomer - to my knowledge at least 'eshell' has no connection to > "comint" - so we apparently cannot put 'display-comint-buffer-action' > into comint.el where it would belong. Yet I'd tend to keep it, after > applying Morgan's fix from Bug#52878, obviously. For consistency with 'pop-to-buffer-same-window', shouldn't then new 'display-comint-buffer-action' have a similar function: (defun pop-to-comint-buffer (buffer &optional norecord) (pop-to-buffer buffer display-comint-buffer-action norecord)) ?