Warning: Non-symbol arguments to cl-defgeneric

Warning: Non-symbol arguments to cl-defgeneric

[Stephen Leake]

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

I've just updated to emacs master HEAD
29c8866c7fcd325995c6fc9b2b18537855fee52c (last time I pulled was Dec
2021), and I'm now getting warnings like:

wisi-parse-common.el: Warning: Non-symbol arguments to cl-defgeneric: (parser wisi-parser)

wisi-parse-common.el:113:2: Error: Non-symbol arguments to cl-defgeneric: (parser wisi-parser)

The relevant code is:

(cl-defstruct wisi-parser
  ;; Per-language values for a wisi parser. Also holds transient
  ;; values set by the current parse, that must be used before the
  ;; next parse starts.

  repair-image
  ;; alist of (TOKEN-ID . STRING); used by repair error

  transaction-log-buffer
  ;; Buffer holding history of communications with parser; one log per
  ;; parser instance.

  (transaction-log-buffer-size wisi-parser-transaction-log-buffer-size-default)
  ;; Max character count to retain in transaction-log-buffer. Set to 0
  ;; to disable log. Default is large enough for all transactions in
  ;; test/ada_mode-incremental_parse.adb with lots of verbosity.
)

(cl-defgeneric wisi-parser-transaction-log-buffer-name ((parser wisi-parser))
  "Return a buffer name for the transaction log buffer.")

What does this warning mean?

full file attached, if that helps.

-- 
-- Stephe

[-- Attachment #2: wisi-parse-common.el --]
[-- Type: application/emacs-lisp, Size: 22608 bytes --]

Re: Warning: Non-symbol arguments to cl-defgeneric

[Stefan Kangas]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> I've just updated to emacs master HEAD
> 29c8866c7fcd325995c6fc9b2b18537855fee52c (last time I pulled was Dec
> 2021), and I'm now getting warnings like:
>
> wisi-parse-common.el: Warning: Non-symbol arguments to cl-defgeneric: (parser wisi-parser)
>
> wisi-parse-common.el:113:2: Error: Non-symbol arguments to cl-defgeneric: (parser wisi-parser)

I can't reproduce this.  Did you try "make bootstrap"?

Re: Warning: Non-symbol arguments to cl-defgeneric

[Stefan Monnier]

> (cl-defgeneric wisi-parser-transaction-log-buffer-name ((parser wisi-parser))
>   "Return a buffer name for the transaction log buffer.")

The arglist here puts a `wisi-parser` specializer on the arg.
That's something you can do in `cl-defmethod` but not in `cl-defgeneric`
(where you can only specify the general shape of the arglist).


        Stefan

Re: Warning: Non-symbol arguments to cl-defgeneric

[Stephen Leake]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> (cl-defgeneric wisi-parser-transaction-log-buffer-name ((parser wisi-parser))
>>   "Return a buffer name for the transaction log buffer.")
>
> The arglist here puts a `wisi-parser` specializer on the arg.
> That's something you can do in `cl-defmethod` but not in `cl-defgeneric`
> (where you can only specify the general shape of the arglist).

Ah, right. Thanks. That does fix the problem.

-- 
-- Stephe