From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Forwording symbols Date: Wed, 19 Jun 2024 14:22:05 +0300 Message-ID: <86le31p482.fsf@gnu.org> References: <87jziod6yc.fsf@gmail.com> <874j9rcuf6.fsf@gmail.com> <87y173bda9.fsf@gmail.com> <87plsfbcd5.fsf@gmail.com> <86cyoeqvfc.fsf@gnu.org> <87frta9pgf.fsf@gmail.com> <86v826p346.fsf@gnu.org> <86r0cup24x.fsf@gnu.org> <874j9q9l37.fsf@gmail.com> <86msnip0ul.fsf@gnu.org> <87tthq830y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eller.helmut@gmail.com, emacs-devel@gnu.org To: Gerd =?iso-8859-1?Q?M=F6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 13:22:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJtOS-0005PA-5O for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 13:22:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtOF-00050X-Nk; Wed, 19 Jun 2024 07:22:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtOE-00050M-7c for emacs-devel@gnu.org; Wed, 19 Jun 2024 07:22:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtOD-0000RL-V0; Wed, 19 Jun 2024 07:22:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/9KDNmtdD2E3Rg4qObcGV1ssv5uSyJWdvzuQscEgEdY=; b=cMsfC0Hj9L8zwSG97yDO vvAAHrAvkIa+/tKuwcXNT0WlyozrHnFbV1aMPfpAHbqSbH3RGKXJrKi1yuBopH83NumjLi2Uh7nUB sORNBPMuyzn48YeXBseIOivxkjRfmacwG30/fvYrRmu45/SB9iSmfKqHY25zzAnP9QMMBm0S9R0VA +ZiOSDLo9WbvQUUbnmOwz9PTPMmVaYWv0rWav5amaPtSEwn/8lCId/1qeIX7k8udm2pX5a589h7vI vyMCazzfkqhgG04l3rPa+ycHRiEKs7ft8ffLydBZQPgOu3WI1lhQzZffNYMwX8QvdTFsj2rrnuP0O KZEkOJMcRZLvQQ==; In-Reply-To: (message from Gerd =?iso-8859-1?Q?M=F6llmann?= on Tue, 18 Jun 2024 21:33:02 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320285 Archived-At: > From: Gerd Möllmann > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Tue, 18 Jun 2024 21:33:02 +0200 > > Helmut Eller writes: > > > On Tue, Jun 18 2024, Eli Zaretskii wrote: > > > >>> Could this be our old friend dump_discard_mem that is too lazy to check > >>> error codes? What happens if you remove the call to > >>> dump_mmap_discard_contents in pdumper_load? > >> > >> Then the build succeeds. > > > > With the patch below, dump_mmap_discard_contents calls the map->release > > callback. I think that was the original reason for having this > > callback. It also adds stricter error checking to dump_discard_mem, but > > that function is now unused. It's not clear to me, when it should be > > used instead of dump_unmap_file. > > Pushed. Thanks, I've cleaned up the MS-Windows bits.