From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: magit copyright assignments Date: Tue, 16 Jul 2024 21:25:03 +0300 Message-ID: <86le21gpog.fsf@gnu.org> References: <87bk31mgue.fsf@jeremybryant.net> <86frsdjm20.fsf@gnu.org> <87v815j30v.fsf@metapensiero.it> <867cdliq8r.fsf@gnu.org> <87ikx5s12c.fsf@metapensiero.it> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11220"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lele Gaifax Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 20:26:43 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTmst-0002he-LS for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 20:26:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTms7-00043a-Vi; Tue, 16 Jul 2024 14:25:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTms0-0003hn-MX for emacs-devel@gnu.org; Tue, 16 Jul 2024 14:25:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTmry-0004Ds-1g; Tue, 16 Jul 2024 14:25:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mvRNiuh5Dx/hQ43zIrAN4QWRmwhgCNO6ck3Hw5Y5z/Y=; b=LqGMVfiuGuwr 9nS1NI5ibmUPgJTYC6yokb41vdnp8pKfKNh6FJF45MnelFWU3A1E96LgqUU5vsQIuWyX0u3lAmG/L dI2P2qJNg1Bhw4EsTEUL7d3atgXbp4ojBrRfFWNHoXcVZUEkQBXZYf34gEHfzKH27MnedLo7lipho x/CloiO38n2sTcuP7q1uIk7PUKoMPCw5ZM4/HButlHNR/fStTMiV38oVA5MFCxzAirP4yrldOGCur PuIhZvqWekwbCjc1pTQldlD5z4z8NtL05DukJuzP1vaVcBgTjP+zyz3KyK/FU9gYoNJf/OAbYJoLu dfYrIf12LYZjoe+NZAUQEA==; In-Reply-To: <87ikx5s12c.fsf@metapensiero.it> (message from Lele Gaifax on Tue, 16 Jul 2024 19:23:39 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321735 Archived-At: > From: Lele Gaifax > Date: Tue, 16 Jul 2024 19:23:39 +0200 > > Eli Zaretskii writes: > > > Thanks, but I think "git annotate" or "C-x v g" will be much more > > useful in this case, since we are only interested in how many lines > > which are currently in the package a given author is responsible for. > > It's your call of course, but it seems strange to me: say I contributed > 20 lines of code some time ago, and in the meantime someone edited it > slightly, splitting it, moving it around, changing indentation... "git > annotate" will say that most of my lines of code "belong" to someone > else, but does that really matter in the context of copyright > assignment? I'd say that I had still contributed those 20 lines of code, > and thus I should sign the assignment paper, shouldn't I? What about the other case: you contributed some code, but later all of that was deleted? I agree that some forensics and maybe "C-x v h" will be needed, but my point is that git-commit-metrics is not necessarily the right starting point, because it could easily show you a very distorted picture.