From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: master 71783e9: Add the string-numeric-lessp function Date: Mon, 22 Feb 2016 01:32:06 +0000 Message-ID: <86k2lxttrd.fsf@gmail.com> References: <20160221043348.25201.81719@vcs.savannah.gnu.org> <87twl2fzaw.fsf@gnus.org> <56CA2C66.7040306@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456104767 26199 80.91.229.3 (22 Feb 2016 01:32:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 01:32:47 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 02:32:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXfMZ-0005iw-Ld for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 02:32:35 +0100 Original-Received: from localhost ([::1]:45649 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfMY-0001HV-Q6 for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 20:32:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfML-0001HP-Cd for emacs-devel@gnu.org; Sun, 21 Feb 2016 20:32:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXfMI-00012j-7K for emacs-devel@gnu.org; Sun, 21 Feb 2016 20:32:21 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:37295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfMI-00012f-0R for emacs-devel@gnu.org; Sun, 21 Feb 2016 20:32:18 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aXfMF-0005Qc-V4 for emacs-devel@gnu.org; Mon, 22 Feb 2016 02:32:16 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 22 Feb 2016 02:32:15 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 22 Feb 2016 02:32:15 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (windows-nt) Cancel-Lock: sha1:G155rp9tgrgh3aQ4+p6XRNNBAjA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200413 Archived-At: On Sun 21 Feb 2016, Paul Eggert wrote: > Lars Ingebrigtsen wrote: >> Feel free to change the name, implementation, or >> anything else. :-) > > Thanks, I did that. The idea of my followup is to use the same algorithm that > GNU ls -v does, rather than invent yet another file name comparison algorithm. > This should also handle very long integers correctly. I also changed the name > to be more like the names used elsewhere. Please feel free to revert. Paul, your patch using the gnulib filevercmp function also needs an update to nt/gnulib.mk to keep the Windows builds working. fns.o: In function `Fstring_version_lessp': C:\emacs\git\emacs\master\obj-mingw64\src/../../src/fns.c:364: undefined reference to `filevercmp' C:\emacs\git\emacs\master\obj-mingw64\src/../../src/fns.c:364:(.text+0x10a2): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `filevercmp' This seems to work: diff --git a/nt/gnulib.mk b/nt/gnulib.mk index 6884bf9..a1d207e 100644 --- a/nt/gnulib.mk +++ b/nt/gnulib.mk @@ -334,6 +334,14 @@ EXTRA_DIST += filemode.h ## end gnulib module filemode +## begin gnulib module filevercmp + +libgnu_a_SOURCES += filevercmp.c + +EXTRA_DIST += filevercmp.h + +## end gnulib module filevercmp + ## begin gnulib module fpending After applying that, master bootstraps for 64bit mingw64 again. AndyM