Re: master 71783e9: Add the string-numeric-lessp function

[Andy Moreton <andrewjmoreton@gmail.com>]

On Sun 21 Feb 2016, Paul Eggert wrote:

> Lars Ingebrigtsen wrote:
>> Feel free to change the name, implementation, or
>> anything else.  :-)
>
> Thanks, I did that.  The idea of my followup is to use the same algorithm that
> GNU ls -v does, rather than invent yet another file name comparison algorithm.
> This should also handle very long integers correctly.  I also changed the name
> to be more like the names used elsewhere.  Please feel free to revert.

Paul, your patch using the gnulib filevercmp function also needs an
update to nt/gnulib.mk to keep the Windows builds working.

fns.o: In function `Fstring_version_lessp':
C:\emacs\git\emacs\master\obj-mingw64\src/../../src/fns.c:364: undefined reference to `filevercmp'
C:\emacs\git\emacs\master\obj-mingw64\src/../../src/fns.c:364:(.text+0x10a2): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `filevercmp'

This seems to work:

diff --git a/nt/gnulib.mk b/nt/gnulib.mk
index 6884bf9..a1d207e 100644
--- a/nt/gnulib.mk
+++ b/nt/gnulib.mk
@@ -334,6 +334,14 @@ EXTRA_DIST += filemode.h

 ## end   gnulib module filemode

+## begin gnulib module filevercmp
+
+libgnu_a_SOURCES += filevercmp.c
+
+EXTRA_DIST += filevercmp.h
+
+## end   gnulib module filevercmp
+
 ## begin gnulib module fpending


After applying that, master bootstraps for 64bit mingw64 again.

    AndyM