From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Thu, 09 Aug 2018 21:49:46 +0100 Message-ID: <86k1ozl0yd.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> <86in4rgt1m.fsf@gmail.com> <83pnyyu0k1.fsf@gnu.org> <86k1p59haq.fsf@gmail.com> <83va8osuz2.fsf@gnu.org> <87ftzrknyg.fsf@tromey.com> <87zhxwig5k.fsf@tromey.com> <86lg9gl7vy.fsf@gmail.com> <87tvo4i9em.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533847686 18558 195.159.176.226 (9 Aug 2018 20:48:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2018 20:48:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 22:48:02 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnrqj-0004hm-Bt for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 22:48:01 +0200 Original-Received: from localhost ([::1]:52758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnrsp-0004Ye-QH for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2018 16:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fnrsf-0004RA-9X for emacs-devel@gnu.org; Thu, 09 Aug 2018 16:50:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fnrsa-0004ba-TZ for emacs-devel@gnu.org; Thu, 09 Aug 2018 16:50:01 -0400 Original-Received: from [195.159.176.226] (port=40168 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fnrsa-0004bH-LO for emacs-devel@gnu.org; Thu, 09 Aug 2018 16:49:56 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fnrqR-0004NL-Rq for emacs-devel@gnu.org; Thu, 09 Aug 2018 22:47:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:EkN3yHFQUNeBYfZ/XhFPH/lk+y8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228345 Archived-At: On Wed 08 Aug 2018, Tom Tromey wrote: >>>>>> "Andy" == Andy Moreton writes: > > Andy> This crashes in data-tests-logcount from test/src/data-tests.el, so there is > Andy> a problem in logcount. > > I couldn't reproduce this, so I would appreciate it if you could look > into it. Thanks. Testing on several builds: - cygwin x86_64 is ok - mingw64 x86_64 crashes in logcount - mingw64 i686 is ok Looking further into this, I think it is an MSYS2 packaging bug. The MSYS2 mingw-w64-x86_64-gmp package is built using this script: https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-gmp/PKGBUILD That script builds both a static library and a shared library, but only installs one of the gmp.h headers from the builds. The GMP static and shared library builds generate slightly different gmp.h headers, so both should be installed in separate locations. c:/msys64/mingw64/include/gmp.h has this (package version 6.1.2-1): /* Instantiated by configure. */ #if ! defined (__GMP_WITHIN_CONFIGURE) #define _LONG_LONG_LIMB 1 #define __GMP_LIBGMP_DLL 0 #endif That is suitable for linking to a static library. If I change it to look like this: /* Instantiated by configure. */ #if ! defined (__GMP_WITHIN_CONFIGURE) #define _LONG_LONG_LIMB 1 #define __GMP_LIBGMP_DLL 1 #endif After rebuilding emacs, logcount works, and data-tests passes. AndyM