From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: The new keymap functions Date: Tue, 16 Nov 2021 22:14:41 +0200 Organization: LINKOV.NET Message-ID: <86k0h8ts66.fsf@mail.linkov.net> References: <87zgq8sfw3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34851"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 16 21:38:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mn5E2-0008ql-JG for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Nov 2021 21:38:42 +0100 Original-Received: from localhost ([::1]:53402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mn5E0-0001sO-Qx for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Nov 2021 15:38:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn5DN-00018F-BV for emacs-devel@gnu.org; Tue, 16 Nov 2021 15:38:01 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:45515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mn5DL-00043a-3r for emacs-devel@gnu.org; Tue, 16 Nov 2021 15:38:00 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id DCF07200005; Tue, 16 Nov 2021 20:37:53 +0000 (UTC) In-Reply-To: <87zgq8sfw3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 13 Nov 2021 07:56:12 +0100") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279583 Archived-At: > keymap-set > keymap-local-set > keymap-global-set > keymap-local-unset > keymap-global-unset > keymap-lookup > > define-keymap and defvar-keymap keep their names, but use the > `kbd-valid-p' syntax. Whereas the name `defvar-keymap' is nice since it's a top-level macro, `define-keymap' looks out of place in the same group of functions. And indeed, such mismatch looks odd: (define-keymap "C-c C-c" #'quit-buffer) (keymap-set map "C-c C-c" #'quit-buffer) What about renaming it to `keymap-define'? Then: (keymap-define "C-c C-c" #'quit-buffer) (keymap-set map "C-c C-c" #'quit-buffer)