From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Sat, 02 Apr 2022 21:09:29 +0300 Organization: LINKOV.NET Message-ID: <86k0c71h72.fsf@mail.linkov.net> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 02 20:21:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naiNk-0009sw-Nx for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 20:21:52 +0200 Original-Received: from localhost ([::1]:47830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naiNj-0002Tv-8d for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 14:21:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naiND-0001pW-Ng for emacs-devel@gnu.org; Sat, 02 Apr 2022 14:21:19 -0400 Original-Received: from [2001:4b98:dc4:8::231] (port=55301 helo=relay11.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naiNB-0004Oj-9y for emacs-devel@gnu.org; Sat, 02 Apr 2022 14:21:18 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5238C100002; Sat, 2 Apr 2022 18:21:10 +0000 (UTC) In-Reply-To: <20220401202425.jfrwqmkm3ffmcm5h@Ergus> (Ergus's message of "Fri, 1 Apr 2022 22:24:25 +0200") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::231 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287720 Archived-At: > Hi again... > > Here I attached a small patch that makes 3 small changes: > > 1) Remove the trailing newline in completions one-column > 2) Use another condition in next-completion to jump to minibuffer. > > Normally next-completion with tabs at the end of the buffer needs an > extra tab because it goes to the end of the last completion before > jumping to the minibuffer or wrap.. That extra tab is because the > condition to jump or wrap was eobp/bobp assuming that there is not text > unproppertized after the last candidate. > > 3) Remove a comment in switch-to-completions. That comment suggested that > the next-completion action must be called inside > minibuffer-completion-help but IMO that is not totally correct when > completion-auto-select has some of the new values. > > Please, if anyone could review,correct and push I would be very > grateful. Do you mean that you fixed the problem reported in bug#54374? I hope Philip could help to verify that your patch works smoothly with the new features completion-auto-select and completion-wrap-movement.