From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arash Esbati Newsgroups: gmane.emacs.devel Subject: Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations Date: Thu, 12 May 2022 13:51:39 +0200 Message-ID: <86k0aroto4.fsf@gnu.org> References: <165225612522.6543.149839793356593222@vcs2.savannah.gnu.org> <20220511080205.93362C01683@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 12 13:54:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1np7OJ-000158-0P for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 13:53:59 +0200 Original-Received: from localhost ([::1]:40258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1np7OH-0001eC-NY for ged-emacs-devel@m.gmane-mx.org; Thu, 12 May 2022 07:53:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np7MP-0000Cc-OL for emacs-devel@gnu.org; Thu, 12 May 2022 07:52:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np7MP-0006gg-EM; Thu, 12 May 2022 07:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=g4qO352KnxvuIA2IyrWLZmK1+LTfW71f3ISMhFYSPUk=; b=cas81/G4UJHI1Q9d33aw h6tlAr+OoF9VuTQ0lyuUDQKkS7kzMFbo6hwp9ZonUFlZ2B+F0x0x6HXqgMOCD4kQyVxZV5LZuFey0 +7+amLcZU5BCFROAm75V3l5PR83csGZ4lPZ59+yQA1XK2CANM5usOENdyk3U1tBx2Mzl0mW4q+e5o UWRd+M2p2zNnYjFKfsdVnoqkCXF1pbCdh+hV7VsP16pmYpOROr0pOKXhDRhR5DOUpK3gcDSW+JSCz Yu0i1K/B07cTwFD0uxk6XhehPTHhpoPUej6Q+yZUjcn7H1fI8SSWwRnhE3zQFNJbp7WPzsMV02n/b X6wryIgKFhQfFg==; Original-Received: from p5b326363.dip0.t-ipconnect.de ([91.50.99.99]:58368 helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1np7MO-0005Qg-Vh; Thu, 12 May 2022 07:52:01 -0400 In-Reply-To: <20220511080205.93362C01683@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Wed, 11 May 2022 04:02:05 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289675 Archived-At: Po Lu via Mailing list for Emacs changes writes: > diff --git a/lisp/avoid.el b/lisp/avoid.el > index b53d84d2e8..c97e51a6f7 100644 > --- a/lisp/avoid.el > +++ b/lisp/avoid.el > @@ -300,12 +300,14 @@ has an integer value is a valid cursor shape. You might want to > redefine this function to suit your own tastes." > (if (null mouse-avoidance-pointer-shapes) > (progn > - (setq mouse-avoidance-pointer-shapes > - (mapcar (lambda (x) (symbol-value (intern x))) > - (all-completions "x-pointer-" obarray > - (lambda (x) > - (and (boundp x) > - (integerp (symbol-value x))))))))) > + (dolist (i (all-completions "x-pointer-" obarray > + (lambda (x) > + (and (boundp x) > + (integerp (symbol-value x)))))) > + (ignore-errors > + (let ((value (symbol-value (intern i)))) > + (when (< value x-pointer-invisible) > + (push value mouse-avoidance-pointer-shapes))))))) > (seq-random-elt mouse-avoidance-pointer-shapes)) I think this change leads to: In mouse-avoidance-random-shape: avoid.el:309:30: Warning: reference to free variable `x-pointer-invisible' when building Emacs (aeefa3a732, on Win10). Best, Arash