From: Arash Esbati <arash@gnu.org>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations
Date: Thu, 12 May 2022 13:51:39 +0200 [thread overview]
Message-ID: <86k0aroto4.fsf@gnu.org> (raw)
In-Reply-To: <20220511080205.93362C01683@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Wed, 11 May 2022 04:02:05 -0400 (EDT)")
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> diff --git a/lisp/avoid.el b/lisp/avoid.el
> index b53d84d2e8..c97e51a6f7 100644
> --- a/lisp/avoid.el
> +++ b/lisp/avoid.el
> @@ -300,12 +300,14 @@ has an integer value is a valid cursor shape. You might want to
> redefine this function to suit your own tastes."
> (if (null mouse-avoidance-pointer-shapes)
> (progn
> - (setq mouse-avoidance-pointer-shapes
> - (mapcar (lambda (x) (symbol-value (intern x)))
> - (all-completions "x-pointer-" obarray
> - (lambda (x)
> - (and (boundp x)
> - (integerp (symbol-value x)))))))))
> + (dolist (i (all-completions "x-pointer-" obarray
> + (lambda (x)
> + (and (boundp x)
> + (integerp (symbol-value x))))))
> + (ignore-errors
> + (let ((value (symbol-value (intern i))))
> + (when (< value x-pointer-invisible)
> + (push value mouse-avoidance-pointer-shapes)))))))
> (seq-random-elt mouse-avoidance-pointer-shapes))
I think this change leads to:
In mouse-avoidance-random-shape:
avoid.el:309:30: Warning: reference to free variable `x-pointer-invisible'
when building Emacs (aeefa3a732, on Win10).
Best, Arash
next parent reply other threads:[~2022-05-12 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165225612522.6543.149839793356593222@vcs2.savannah.gnu.org>
[not found] ` <20220511080205.93362C01683@vcs2.savannah.gnu.org>
2022-05-12 11:51 ` Arash Esbati [this message]
2022-05-12 12:27 ` master 95717db1e8: Fix mouse pointer avoidance in some configurations Po Lu
2022-05-12 12:38 ` Arash Esbati
2022-05-19 14:09 ` Arash Esbati
2022-05-27 7:56 ` Stefan Kangas
2022-05-27 8:04 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k0aroto4.fsf@gnu.org \
--to=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).