From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Task Newsgroups: gmane.emacs.devel Subject: Re: Extending timeclock.el Date: Sat, 06 May 2023 15:35:29 -0300 Message-ID: <86jzxl9u9d.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8712"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 06 21:40:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvNls-00023T-Fb for ged-emacs-devel@m.gmane-mx.org; Sat, 06 May 2023 21:40:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvNlP-0004yz-Cp; Sat, 06 May 2023 15:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvMqt-0004MO-9J for emacs-devel@gnu.org; Sat, 06 May 2023 14:41:51 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvMqr-0001vH-Ht; Sat, 06 May 2023 14:41:50 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id EBF06402BC; Sat, 6 May 2023 20:41:47 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HMD3IThj9k2j; Sat, 6 May 2023 20:41:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1683398506; bh=E5P/ROPKWg2n5vIMuQrdffjFqyEOA6ymkZ1WS1ArHOo=; h=From:To:Cc:Subject:Date; b=ZNvUQgdpxpZ/6KutW2DN26sgw3DmPilaHAlSsOiJmUtS/ch65L1bu+SCSi3ZfpKB5 5/LHRaN/wJWdaHkjg4JlHhLhwFnyMDAtrGTJLQABIrpNBXH4it/cbd1rzvSAzudG3X +GGBtpmQqY+6hKBth6gEL4RgEscTSFrW88xO7jP89kpfXC5CRDktwqfUYdPWK+iHpK FTMA5Refrmr31lIKtS7Dhx0spJ0xWjIl53CTBZCODdPLqjusaYb+9gVAkqNXLIdUXt r0kPai/fEs6nPH6nxVm/YiTxUuBbGU6+saOh9nRpwvPUEgrbZ27bIeVFnO17/GPp8w kZ7CMhW1iG3Yw== Received-SPF: pass client-ip=178.21.23.139; envelope-from=q01@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 06 May 2023 15:40:11 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305936 Archived-At: Eli Zaretskii writes: > The way we extend existing packages is by adding code to the existing > files, not by starting new FOO-x.el files. This is a natural way of > extending them, even if the extension adds something that is only > loosely coupled with the previous functionalities. Noted, thanks. > I'm not sure this is being used. Do you see any code that logs "b" > lines in the file? Interesting. I looked at the code and it seems that nothing logs "b" lines in the file. Maybe it was removed? Anyway, I think I can safely ignore it then. > I'm guessing that this means you move the log file to some archive, > e.g., when a year ends or something. Yes, that makes sense. Though archiving log files doesn't seem too statistic-friendly... Maybe I'll have to warn about that somewhere. > You don't have to design and implement anything that didn't exist > unless you think it's a must-to-have feature. We can always wait for > users to request such a feature in some distant future. What I > described was just a rationale for having "O", and my point was that > allowing people to say the project is finished is useful even if for > now this is largely unused. OK. > As I said, the timelog file could announce what kind it is of. Yes, that would be a solution. I implemented a safe comment string already, so something like #+FORMAT: should do the trick. > You can build tests using the ert package. We use it in our test > suite (under the test/ subdirectory of the Emacs source tree). Good. I'll look into that.