From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: desktop fails to restore dired buffers
Date: Thu, 07 Dec 2023 21:20:25 +0000 [thread overview]
Message-ID: <86jzppiuau.fsf@gmail.com> (raw)
In-Reply-To: 83fs0e326g.fsf@gnu.org
On Thu 07 Dec 2023, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Wed, 06 Dec 2023 21:28:44 +0000
>>
>>
>> Commit ce4a62eece60 ("Fix desktop-save on remote dired (bug#66697)") on
>> the master branch changed how dired buffers are saved by desktop-save,
>> so they are no longer restored in my setup.
>>
>> The code in `dired-desktop-save-p' and `dired-desktop-buffer-misc-data'
>> now assumes that `desktop-files-not-to-save' always has a string value.
>>
>> However I have `desktop-files-not-to-save' as nil, which is a valid
>> value according to its definition. That fails the checks, and so
>> dired buffers are not saved.
>>
>> Please can this oversight be fixed ?
>
> Manuel, could you please look into this issue?
>
> P.S. This should have been posted to the bug tracker, not here.
I did that, and reopening an archived bug did not work for some reason.
I gave up and posted here to capture the problem.
From some experimentation, it seem that replacing:
desktop-files-not-to-save
with:
(or desktop-files-not-to-save "")
seems to restore the original behaviour.
AndyM
next prev parent reply other threads:[~2023-12-07 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 21:28 desktop fails to restore dired buffers Andy Moreton
2023-12-07 7:24 ` Eli Zaretskii
2023-12-07 21:20 ` Andy Moreton [this message]
2023-12-08 13:59 ` Manuel Giraud via Emacs development discussions.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzppiuau.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).