From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) Date: Sun, 07 Apr 2024 08:57:10 +0300 Message-ID: <86jzl91zrd.fsf@gnu.org> References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org, philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org, hmelman@gmail.com, info@protesilaos.com To: =?utf-8?Q?S=C5=82awomir?= Grochowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 07 07:58:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtLXg-0003K6-8j for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Apr 2024 07:58:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtLWl-0004pH-TE; Sun, 07 Apr 2024 01:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtLWk-0004oG-4i; Sun, 07 Apr 2024 01:57:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtLWi-0004ho-8X; Sun, 07 Apr 2024 01:57:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=451EJXr6WY0I1ENQ/E3MWeE/cmEzvHGDpQcURkU2hSU=; b=EOuCpNokRoiZ8qNciMkK zdYFkUi2m/3mHsWpD5NFZSb9Dv47JEAPqtjdsfQqUURUjfRL+H5C0uet9J6uzj33eJ09hoatTlXy0 wWrbbkaLTjnMOMOLjJVu2BUksD4a+vIXhYn6AdKH8dzu9KoXNepahhayRonOwXlSn6NCO0ujIf7Um mSqzRG2lLGxN0bdbHgdqisZSYiNh4pcKWQHoSLBU0Wwitk/iXiJXRqtHWQrYN1wiQc4bYFKXQ9IeT Lsckh4YrrrMiAe3Kmi6T37sC9i/R+ugfo/tQZM44RRcznVWTvt5BIu3zpcUsdTdFilLxjPFR9JXGa /X4l6lKAi8z1hw==; In-Reply-To: <87zfu6b4w3.fsf@gmail.com> (message from =?utf-8?Q?S=C5=82awo?= =?utf-8?Q?mir?= Grochowski on Sat, 06 Apr 2024 22:41:32 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317582 gmane.emacs.orgmode:160901 Archived-At: > From: SÅ‚awomir Grochowski > Cc: emacs-orgmode@gnu.org, emacs-devel@gnu.org, philipk@posteo.net, > stefankangas@gmail.com, larsi@gnus.org, hmelman@gmail.com, eliz@gnu.org, > info@protesilaos.com > Date: Sat, 06 Apr 2024 22:41:32 +0200 > > But first, we need to modify `help-quick' to be more reusable. > I tried to do it, but I'm not experienced in elisp. > I wanted to remove references to global variables, so I did a wrapper > function to pass arguments to `help-quick'. I understand it's not a lispy way. > I would be grateful for your comment. I don't understand why you needed a wrapper. help-quick is already customizable by modes, via the help-quick-sections variable. In any case, we cannot change the signature of help-quick, since it's a public function.