From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Fri, 16 Aug 2024 20:48:00 +0300 Message-ID: <86jzgg5pgv.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 16 19:48:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sf146-000A47-Kb for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Aug 2024 19:48:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sf13U-0006OB-Pq; Fri, 16 Aug 2024 13:48:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sf13T-0006Md-Rb for emacs-devel@gnu.org; Fri, 16 Aug 2024 13:48:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sf13T-00042e-I4; Fri, 16 Aug 2024 13:48:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Lr0926zL/bgUZIyeRcg1TLtXhRrymnx+awoBBb1bl2I=; b=nt7MnKpugXkSYQ/vMale /gd+RGsRTckL1hBBwfq3zJFMNBFJBFnhEyHNqf/boOgQfZoHA+i6DGMMtzC6L+sdhmW2SeifgjaiH UqvrHsL2qsFGq8cfJz1R4ahsLHSkYpFW9fgVCa2gZaSlsOCCf+4r8yJkZM3EQnJ5+xpdfmL3SMvV8 eGnWNr9YEs3X/EHzUPOfbCTwk38asTYzFJKTHIHDt76ygMc5fp/xG9LtjJTHhqpSoRA9+JfMh4uaH 1XN+PnoV3AqG3JdPIQo3SHkmGh3vjlsDQU0+e/xh0NbxEO+LI9djS9tB95IRXGkfbdE+GX7UlFyCO YW0UKrE0sz6rBQ==; In-Reply-To: (message from =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= on Fri, 16 Aug 2024 13:28:54 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322812 Archived-At: > From: Sebastián Monía > Date: Fri, 16 Aug 2024 13:28:54 -0400 > > Small quality of life change in EWW. I was interested in reverting the > buffer list, then I found the "FIXME" note about reverting in > eww-mode, and figured, why not :) > > I didn't want to alter eww-reload (since it is part of the public API) > hence the new function for reverting that just calls it. Is it really TRT to call eww-reload? The FIXME says we need a real revert-buffer-function, so I presume just calling eww-reload is somehow not the best solution? In any case, what is the improvement provided by this change? Thanks.