From: Eli Zaretskii <eliz@gnu.org>
To: "Sebastián Monía" <sebastian@sebasmonia.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer
Date: Fri, 16 Aug 2024 20:48:00 +0300 [thread overview]
Message-ID: <86jzgg5pgv.fsf@gnu.org> (raw)
In-Reply-To: <thqnr0aoz8a1.fsf@sebasmonia.com> (message from Sebastián Monía on Fri, 16 Aug 2024 13:28:54 -0400)
> From: Sebastián Monía <sebastian@sebasmonia.com>
> Date: Fri, 16 Aug 2024 13:28:54 -0400
>
> Small quality of life change in EWW. I was interested in reverting the
> buffer list, then I found the "FIXME" note about reverting in
> eww-mode, and figured, why not :)
>
> I didn't want to alter eww-reload (since it is part of the public API)
> hence the new function for reverting that just calls it.
Is it really TRT to call eww-reload? The FIXME says we need a real
revert-buffer-function, so I presume just calling eww-reload is
somehow not the best solution?
In any case, what is the improvement provided by this change?
Thanks.
next prev parent reply other threads:[~2024-08-16 17:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 17:28 [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Sebastián Monía
2024-08-16 17:48 ` Eli Zaretskii [this message]
2024-08-16 18:55 ` Sebastián Monía
2024-08-17 12:35 ` Sebastián Monía
2024-08-24 8:42 ` Eli Zaretskii
2024-08-24 17:27 ` Jim Porter
2024-08-30 20:01 ` Sebastián Monía
2024-09-14 7:32 ` Eli Zaretskii
[not found] ` <thqnjzf7s74l.fsf@sebasmonia.com>
2024-09-20 6:18 ` Eli Zaretskii
2024-09-20 15:06 ` Sebastián Monía
2024-09-20 17:43 ` Jim Porter
2024-09-21 2:14 ` Sebastián Monía
2024-10-02 12:53 ` Sebastián Monía
2024-10-03 0:20 ` Adam Porter
2024-10-03 3:17 ` Sebastián Monía
2024-10-03 4:05 ` Jim Porter
2024-10-03 12:47 ` Sebastián Monía
2024-10-03 23:41 ` Adam Porter
2024-10-11 22:14 ` Sebastián Monía
2024-10-12 8:05 ` Eli Zaretskii
2024-10-12 18:56 ` Jim Porter
2024-10-14 1:06 ` Sebastián Monía
2024-10-14 2:39 ` Adam Porter
2024-10-14 4:06 ` Sebastián Monía
2024-10-15 0:08 ` Adam Porter
2024-10-15 2:39 ` Sebastián Monía
2024-10-15 4:04 ` Adam Porter
2024-10-14 4:05 ` Jim Porter
2024-10-15 2:59 ` Sebastián Monía
2024-10-15 4:01 ` Adam Porter
[not found] ` <thqnh69apzgp.fsf@sebasmonia.com>
2024-10-19 20:51 ` Sebastián Monía
2024-10-20 17:50 ` Jim Porter
2024-10-21 1:57 ` Sebastián Monía
2024-10-03 21:58 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzgg5pgv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=sebastian@sebasmonia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).