From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Sat, 21 Sep 2024 10:14:20 +0300 Message-ID: <86jzf55vhv.fsf@gnu.org> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87frpvo06a.fsf@posteo.net> <86y13m7swd.fsf@gnu.org> <87bk0inyr1.fsf@posteo.net> <86zfo25nxf.fsf@gnu.org> <87o74im4y8.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16346"; mail-complaints-to="usenet@ciao.gmane.io" Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, tonyzorman@mailbox.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 21 09:15:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sruKp-00043W-OF for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Sep 2024 09:15:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sruK4-0000qy-8Z; Sat, 21 Sep 2024 03:14:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sruK2-0000qZ-S7 for emacs-devel@gnu.org; Sat, 21 Sep 2024 03:14:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sruJz-0002om-62; Sat, 21 Sep 2024 03:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jIeFQl0VY1zo1Tz3mP9xirY70aDT/vWY5Iduz5wTn9Y=; b=mAUpgASGlAEs I/KPtDsWv4I6XK+etC6L9nS1ON0U/Y0Zq8VOgfKNZT9AKhD4r2gSDh21hVjIb8iuhVj3WUWCwhEmZ 7IM2bvXoemgFgL8OSENyLVXlQ99p+pr5vBsF4BCzwJ7ueXvCKc32fwDBq094gjHfBPv28TWtTdnPN DkgP6wpI+vFEqKUspyn7uZAx204rLzt9iXWz9hqRRkpRCKhAaF6yYJqe7lArfQO1KUHAbX2uT2s/f fl6al6YUHUU88bmcEBzElTECsVGMJerKBO/A8hogvKocdXPX1oCmmkROF/WzdEDmSiN8Ob3vR5JRy tRjBYRwp9e9IxLPKjLDx7Q==; In-Reply-To: <87o74im4y8.fsf@posteo.net> (message from Philip Kaludercic on Fri, 20 Sep 2024 20:43:27 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323881 Archived-At: > From: Philip Kaludercic > Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, > tonyzorman@mailbox.org > Date: Fri, 20 Sep 2024 20:43:27 +0000 > > Eli Zaretskii writes: > > >> From: Philip Kaludercic > >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org, > >> tonyzorman@mailbox.org > >> Date: Fri, 20 Sep 2024 15:14:26 +0000 > >> > >> Eli Zaretskii writes: > >> > >> >> This is the fix: > >> > > >> > Can you explain in plain English what this does? > >> > >> Sure, each package has a description object (search for "(cl-defstruct > >> (package-desc" in package.el), with some fixed attributes like name, > >> version, dependencies and others that are stored in an alist. The > >> commit used to create a package is one such attribute stored in the > >> "extras" slot of a package-desc. My chance modifies the package > >> description given by the ELPA server and updates the :commit field to > >> store the commit that was checked out when the package was built > >> locally. I hope that is clear enough? > > > > Yes, thanks. What was the :commit field storing before the change? > > The commit the ELPA build server used to release a new version of the > package. That is not right, I agree. > M-x list-packages lists the commit of the local checkout for > VC packages, btw. What is "the local checkout" in this context? > I could have sworn that M-x describe-package did the same. Shouldn't they all be consistent in what commit they show?