Emacs master build broken [GNU/Linux?]

Emacs master build broken [GNU/Linux?]

[Angelo Graziosi]

At least on GNU/Linux Mint the build of Emacs from master is broken:


[...]
   CC       lastfile.o
image.c: In function ‘svg_load_image’:
image.c:12358:12: warning: implicit declaration of function 
‘rsvg_handle_get_pixbuf_and_error’; did you mean 
‘rsvg_handle_get_pixbuf_sub’? [-Wimplicit-function-declaration]
12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |            rsvg_handle_get_pixbuf_sub
image.c:12358:10: warning: assignment to ‘GdkPixbuf *’ {aka ‘struct 
_GdkPixbuf *’} from ‘int’ makes pointer from integer without a cast 
[-Wint-conversion]
12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
       |          ^
   CCLD     temacs
   GEN      ../etc/DOC
/usr/bin/ld: image.o: in function `svg_load_image':
image.c:(.text+0x7d88): undefined reference to 
`rsvg_handle_get_pixbuf_and_error'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:745: temacs] Errore 1
make[2]: uscita dalla directory «/tmp/emacs-master/src»
make[1]: *** [Makefile:554: src] Errore 2
make[1]: uscita dalla directory «/tmp/emacs-master»
make[1]: ingresso nella directory «/tmp/emacs-master»
***
*** "make all" failed with exit status 2.
***
*** You could try to:
*** - run "make bootstrap", which might fix the problem
*** - run "make V=1", which displays the full commands invoked by make,
***   to further investigate the problem
***
make[1]: *** [Makefile:418: advice-on-failure] Errore 2
make[1]: uscita dalla directory «/tmp/emacs-master»
make: *** [Makefile:374: all] Errore 2
Error: Failure running MAKE

I always do a clean build from 
https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-master.tar.gz.

Ciao,
  Angelo.

Re: Emacs master build broken [GNU/Linux?]

[Jim Myhrberg]

[-- Attachment #1: Type: text/plain, Size: 2529 bytes --]

If it helps at all, it's broken on macOS as well, both x86_64 and arm64.

My nightly build just failed from commit
f9e7f57f5710fe929fce468f8875a7310e73be05. Build log is available here:
https://github.com/jimeh/emacs-builds/actions/runs/12129499436/job/33818102923

The most recent change to line yielding the error is
commit 748b19e56e87fab44cb5474613502f8e96064a46 "Update to version 2.58 of
librsvg API (bug#74606)".

My nightly build environment has librsvg v2.58.3 installed, so all things
seem to line up :)

On Mon, Dec 2, 2024 at 10:44 PM Angelo Graziosi <angelo.g0@libero.it> wrote:

> At least on GNU/Linux Mint the build of Emacs from master is broken:
>
>
> [...]
>    CC       lastfile.o
> image.c: In function ‘svg_load_image’:
> image.c:12358:12: warning: implicit declaration of function
> ‘rsvg_handle_get_pixbuf_and_error’; did you mean
> ‘rsvg_handle_get_pixbuf_sub’? [-Wimplicit-function-declaration]
> 12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
>        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        |            rsvg_handle_get_pixbuf_sub
> image.c:12358:10: warning: assignment to ‘GdkPixbuf *’ {aka ‘struct
> _GdkPixbuf *’} from ‘int’ makes pointer from integer without a cast
> [-Wint-conversion]
> 12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
>        |          ^
>    CCLD     temacs
>    GEN      ../etc/DOC
> /usr/bin/ld: image.o: in function `svg_load_image':
> image.c:(.text+0x7d88): undefined reference to
> `rsvg_handle_get_pixbuf_and_error'
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:745: temacs] Errore 1
> make[2]: uscita dalla directory «/tmp/emacs-master/src»
> make[1]: *** [Makefile:554: src] Errore 2
> make[1]: uscita dalla directory «/tmp/emacs-master»
> make[1]: ingresso nella directory «/tmp/emacs-master»
> ***
> *** "make all" failed with exit status 2.
> ***
> *** You could try to:
> *** - run "make bootstrap", which might fix the problem
> *** - run "make V=1", which displays the full commands invoked by make,
> ***   to further investigate the problem
> ***
> make[1]: *** [Makefile:418: advice-on-failure] Errore 2
> make[1]: uscita dalla directory «/tmp/emacs-master»
> make: *** [Makefile:374: all] Errore 2
> Error: Failure running MAKE
>
> I always do a clean build from
> https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-master.tar.gz.
>
> Ciao,
>   Angelo.
>
>
>

[-- Attachment #2: Type: text/html, Size: 3362 bytes --]

Re: Emacs master build broken [GNU/Linux?]

[Jim Myhrberg]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

Commit f65de1019dca6398097751abefcad7e1a4637551 on the emacs-30 branch
fixes the issue. Seems the change was meant for librsvg 2.59.x rather than
2.58.x.

[-- Attachment #2: Type: text/html, Size: 179 bytes --]

Re: Emacs master build broken [GNU/Linux?]

[Eli Zaretskii]

> Date: Mon, 2 Dec 2024 23:42:47 +0100
> From: Angelo Graziosi <angelo.g0@libero.it>
> 
> At least on GNU/Linux Mint the build of Emacs from master is broken:
> 
> 
> [...]
>    CC       lastfile.o
> image.c: In function ‘svg_load_image’:
> image.c:12358:12: warning: implicit declaration of function 
> ‘rsvg_handle_get_pixbuf_and_error’; did you mean 
> ‘rsvg_handle_get_pixbuf_sub’? [-Wimplicit-function-declaration]
> 12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
>        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        |            rsvg_handle_get_pixbuf_sub
> image.c:12358:10: warning: assignment to ‘GdkPixbuf *’ {aka ‘struct 
> _GdkPixbuf *’} from ‘int’ makes pointer from integer without a cast 
> [-Wint-conversion]
> 12358 |   pixbuf = rsvg_handle_get_pixbuf_and_error (rsvg_handle, &err);
>        |          ^
>    CCLD     temacs
>    GEN      ../etc/DOC
> /usr/bin/ld: image.o: in function `svg_load_image':
> image.c:(.text+0x7d88): undefined reference to 
> `rsvg_handle_get_pixbuf_and_error'
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:745: temacs] Errore 1
> make[2]: uscita dalla directory «/tmp/emacs-master/src»
> make[1]: *** [Makefile:554: src] Errore 2
> make[1]: uscita dalla directory «/tmp/emacs-master»
> make[1]: ingresso nella directory «/tmp/emacs-master»
> ***
> *** "make all" failed with exit status 2.
> ***
> *** You could try to:
> *** - run "make bootstrap", which might fix the problem
> *** - run "make V=1", which displays the full commands invoked by make,
> ***   to further investigate the problem
> ***
> make[1]: *** [Makefile:418: advice-on-failure] Errore 2
> make[1]: uscita dalla directory «/tmp/emacs-master»
> make: *** [Makefile:374: all] Errore 2
> Error: Failure running MAKE
> 
> I always do a clean build from 
> https://git.savannah.gnu.org/cgit/emacs.git/snapshot/emacs-master.tar.gz.

This was fixed on the emacs-30 branch yesterday, so wait for a few
days for it to be merged to master.