From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: unload-feature questions and thoughts Date: Mon, 05 Feb 2007 12:16:18 +0100 Message-ID: <86iregq2gt.fsf@lola.quinscape.zz> References: <85bqk9db9a.fsf@lola.goethe.zz> <851wl5d9b2.fsf@lola.goethe.zz> <86r6t5qdbo.fsf@lola.quinscape.zz> <861wl5q7al.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170674393 15367 80.91.229.12 (5 Feb 2007 11:19:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2007 11:19:53 +0000 (UTC) Cc: Emacs Devel To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 05 12:19:47 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HE1su-0004WQ-RO for ged-emacs-devel@m.gmane.org; Mon, 05 Feb 2007 12:19:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HE1st-0007nF-Gi for ged-emacs-devel@m.gmane.org; Mon, 05 Feb 2007 06:19:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HE1pr-0007E8-Km for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:16:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HE1pp-0007Ds-VE for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:16:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HE1pp-0007Dl-Lc for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:16:33 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HE1pp-00078b-C9 for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:16:33 -0500 Original-Received: from pc3.berlin.powerweb.de ([62.67.228.11]) by mx20.gnu.org with esmtp (Exim 4.52) id 1HE1po-0001N0-7a for emacs-devel@gnu.org; Mon, 05 Feb 2007 06:16:32 -0500 Original-Received: from quinscape.de (pd95b0fdb.dip0.t-ipconnect.de [217.91.15.219]) by pc3.berlin.powerweb.de (8.9.3p3/8.9.3) with ESMTP id MAA03399 for ; Mon, 5 Feb 2007 12:16:26 +0100 X-Delivered-To: Original-Received: (qmail 19711 invoked from network); 5 Feb 2007 11:16:29 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by ns.quinscape.de (qmail-ldap-1.03) with SMTP for ; 5 Feb 2007 11:16:29 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id 23BF7C2B64; Mon, 5 Feb 2007 12:16:19 +0100 (CET) In-Reply-To: (Juanma Barranquero's message of "Mon\, 5 Feb 2007 12\:08\:28 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65908 Archived-At: "Juanma Barranquero" writes: > On 2/5/07, David Kastrup wrote: > >> Could you think of something in code or docs that should have >> prevented the confusion? > > I misread the code (I was much more centered in the part about undoing > defun, provide, etc. and didn't take a closer look to the beginning of > the function), but I think this piece of docstring is a bit confusing > > This function tries to undo modifications made by the package to > hooks. Packages may define a hook FEATURE-unload-hook that is called > instead of the normal heuristics for doing this. Such a hook should > undo all the relevant global state changes that may have been made by > loading the package or executing functions in it. > > because if you miss the "to hooks" (two words), as I did in several > readings, it seems like it is saying that either you define > FEATURE-unload-hook, or else it uses "the normal heuristics". Maybe "the normal heuristics" and "all the relevant global state changes" are far too much hand-waving: readers will probably phantasize whatever they would think useful into it. -- David Kastrup