From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Emacs rewrite in a maintainable language Date: Tue, 13 Oct 2015 22:02:38 +0100 Message-ID: <86io6amqhd.fsf@gmail.com> References: <561A19AB.5060001@cumego.com> <87io6dl0h0.fsf@wanadoo.es> <87lhb82qxc.fsf@gmail.com> <878u78b3hg.fsf@fencepost.gnu.org> <87h9lwyv33.fsf@gmail.com> <561C368F.6010306@cs.ucla.edu> <87oag3xb2i.fsf@gmail.com> <561D241E.1010902@cs.ucla.edu> <87vbaaagr5.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444770274 1405 80.91.229.3 (13 Oct 2015 21:04:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 21:04:34 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 13 23:04:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zm6k5-00030J-Rt for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 23:04:18 +0200 Original-Received: from localhost ([::1]:39338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6k5-0001uQ-1o for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 17:04:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6is-0001qj-Qo for emacs-devel@gnu.org; Tue, 13 Oct 2015 17:03:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm6in-0004LQ-R9 for emacs-devel@gnu.org; Tue, 13 Oct 2015 17:03:02 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:58796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm6in-0004L3-L4 for emacs-devel@gnu.org; Tue, 13 Oct 2015 17:02:57 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zm6id-0001PI-Bk for emacs-devel@gnu.org; Tue, 13 Oct 2015 23:02:47 +0200 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 13 Oct 2015 23:02:47 +0200 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 13 Oct 2015 23:02:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (windows-nt) Cancel-Lock: sha1:RtYsBtR1ERCjHiTmAbbEh5doV44= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191512 Archived-At: On Tue 13 Oct 2015, Oleh Krehel wrote: > Paul Eggert writes: > >> Oleh Krehel wrote: >>> I'd like to switch all const >>> pointers to a single "const char *" style. >> >> Let's not. It's more consistent to put 'const' after the type it >> modifies, and if we're going to have a "standard" style, that's the >> one we should have. > > "const char *" style is used in 85.9% of the cases. If you want to > revert those uses to "char const *" I'll support you, since I want the > consistency of a single style. Consistency is helpful, but pointless churn makes version history less useful, so please don't make this kind of change unless you are also making a semantic change to that area of the code. >> But really, we have better things to do. > > I don't. I have no problem spending time to replace "char const *" into > "const char *". Browsing through a code base that I want to get familiar > with and fixing a small annoyance doesn't sound bad to me. Pointless churn. Find something that fixes an bug, or adds a useful new feature, and work on that. You will find it more rewarding, and other users and developers will find your contribution more helpful. AndyM