From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 03 Aug 2018 20:16:05 +0100 Message-ID: <86in4rgt1m.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> <87wot71hpb.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533323665 26423 195.159.176.226 (3 Aug 2018 19:14:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 19:14:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 03 21:14:21 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flfWm-0006mz-JW for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 21:14:20 +0200 Original-Received: from localhost ([::1]:52809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flfYt-0002PC-7f for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 15:16:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flfYj-0002Nv-ES for emacs-devel@gnu.org; Fri, 03 Aug 2018 15:16:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flfYg-00067k-A7 for emacs-devel@gnu.org; Fri, 03 Aug 2018 15:16:21 -0400 Original-Received: from [195.159.176.226] (port=46609 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flfYf-000668-UY for emacs-devel@gnu.org; Fri, 03 Aug 2018 15:16:18 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1flfWV-0006TP-8S for emacs-devel@gnu.org; Fri, 03 Aug 2018 21:14:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:x2bM5IzUoaWYDZaEJd43a+WuJwc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228134 Archived-At: On Fri 03 Aug 2018, Tom Tromey wrote: >>>>>> "Eli" == Eli Zaretskii writes: > > Eli> Btw, isn't it confusing that INTEGERP allows fixnums and bignums, but > Eli> XINT, XFASTINT, and XSETINT work only with fixnums? I envision quite > Eli> a few of potential bugs due to this semantic discrepancy, like the one > Eli> you just fixed: > >>> - fix NUMBERP to remove redundant BIGNUMP test (ensured by INTEGERP) > > Eli> Should we have a different name for what is now INTEGERP? Like > Eli> WHOLENUMP, for example? > > Paul suggested this and it made sense to me, as a bignum is an integer. > Perhaps one fix would be to take some of the renaming further and use > XFIXNUM, XFASTFIXNUM, and XSETFIXNUM. Yes. Also perhaps change XBIGNUM to: INLINE struct Lisp_Bignum * XBIGNUM (Lisp_Object a) { eassert (BIGNUMP (a)); return XUNTAG (a, Lisp_Misc, struct Lisp_Bignum)->value; } That allows "XBIGNUM(value)->value" to be replaced with "XBIGNUM(value)" in all callers. AndyM