From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Duplicated outline-cycle binding, and problems with the new one Date: Sun, 02 Jan 2022 20:25:43 +0200 Organization: LINKOV.NET Message-ID: <86ilv25714.fsf@mail.linkov.net> References: <9DFDAD07-DBC0-4FAE-A565-D1EE6045E7D8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="753"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Emacs developers To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 02 19:28:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n45b0-000AaI-BY for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 19:28:42 +0100 Original-Received: from localhost ([::1]:40456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n45az-0003wT-62 for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 13:28:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n45Zg-0002ZD-G4 for emacs-devel@gnu.org; Sun, 02 Jan 2022 13:27:20 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:52821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n45Ze-0002Ll-Kc for emacs-devel@gnu.org; Sun, 02 Jan 2022 13:27:20 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 007EE240007; Sun, 2 Jan 2022 18:27:14 +0000 (UTC) In-Reply-To: <9DFDAD07-DBC0-4FAE-A565-D1EE6045E7D8@gmail.com> (Yuan Fu's message of "Fri, 31 Dec 2021 15:32:25 -0800") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283944 Archived-At: > Which presumably are applied as keymap text properties to headings in > a buffer. I’m having problems with this: some text that are not > headings in my buffer are incorrectly propertied with this keymap, and > when I try to indent with TAB, outline-cycle is invoked. This looks like a bug, maybe you have a wrong outline-regexp. > Overall, from my limited knowledge, I think the old approach is more > reliable: I wouldn’t have this problem with the old approach. And the > new functionality added by the new approach and > outline-minor-mode-cycle-filter can be easily implemented in the old > approach. We don’t need to fiddle with font-lock-keywords with the > old approach, either. How about we go back to the old approach? Some time ago we discussed this possibility, but it will require writing too many wrappers for different modes, for example, for diff-mode: (defvar-keymap diff-mode-shared-map "TAB" (lambda () (interactive) (if (and outline-minor-mode (outline-on-heading-p)) (outline-cycle) (diff-hunk-next))) ...