* Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.
[not found] ` <20240315082934.ED7D3C1FB4C@vcs2.savannah.gnu.org>
@ 2024-03-15 11:12 ` Po Lu
2024-03-15 11:47 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Po Lu @ 2024-03-15 11:12 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
Eli Zaretskii <eliz@gnu.org> writes:
> +widgets; kill all xwidget-webkit buffers for changes in this setting
> +to take effect. */);
But this isn't true: the changes will take effect in new WebKit widgets
whether or not some widgets already exist with a different value of this
setting.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix.
2024-03-15 11:12 ` master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix Po Lu
@ 2024-03-15 11:47 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-03-15 11:47 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 15 Mar 2024 19:12:03 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > +widgets; kill all xwidget-webkit buffers for changes in this setting
> > +to take effect. */);
>
> But this isn't true: the changes will take effect in new WebKit widgets
> whether or not some widgets already exist with a different value of this
> setting.
Feel free to rephrase, but please do NOT lose practical information,
which is important to users, and without which that part of the doc
string is basically useless. We must tell users what to do after they
change the value of the variable, for the doc string to be of any use.
(And in the future, may I suggest that you discuss your changes that
remove useful information, before going ahead and silently making
unilateral changes like this one? Not only will it be more polite, it
will also lower the probability of letting less-than-useful doc
strings slip past us into the release.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-15 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171049137450.14047.14690023335994985946@vcs2.savannah.gnu.org>
[not found] ` <20240315082934.ED7D3C1FB4C@vcs2.savannah.gnu.org>
2024-03-15 11:12 ` master ebd32040e06: ; * src/xwidget.c (xwidget-webkit-disable-javascript): Doc fix Po Lu
2024-03-15 11:47 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).