Re: "Final" version of tty child frames

[Eli Zaretskii <eliz@gnu.org>]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  stefankangas@gmail.com,
>   acorallo@gnu.org,  emacs-devel@gnu.org,  rudalics@gmx.at
> Date: Thu, 19 Dec 2024 06:30:23 +0100
> 
> And attached is what I came up today, with the help of a lot of coffee.
> The changelog is a page worth of changelog entries, the diff is from
> what I created these. As introductory text I'd use
> 
>   This changeset adds support for child frames on ttys.

I'd say

  Add support for child frames on ttys

(without the period).

The ChangeLog part looks reasonable.  My only comment is that you
could collect changes with the same description together.  For
example, instead of

	* lisp/frame.el (frame-at): New function.
	(tty-frame-geometry): Declare C function.
	(tty-frame-edges): Declare C function.
	(tty-frame-list-z-order): Declare C function.
	(tty-frame-restack): Declare C function.
	(tty-display-pixel-height): Declare C function.
	(tty-display-pixel-width): Declare C function.

you could use

	* lisp/frame.el (frame-at): New function.
	(tty-frame-geometry, tty-frame-edges, tty-frame-list-z-order)
	(tty-frame-restack, tty-display-pixel-height)
	(tty-display-pixel-width): Declare C function.

But that's an optimization; what you have is perfectly okay.

Thanks.