From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: nadvice compatibility in package list
Date: Sat, 06 Jul 2019 19:15:20 +0100 [thread overview]
Message-ID: <86h87z2fnr.fsf@gmail.com> (raw)
In-Reply-To: jwvd0ince8h.fsf-monnier+emacs@gnu.org
On Sat 06 Jul 2019, Stefan Monnier wrote:
>> Stefan, your patch gives the right assoc lookups, but does not show the
>> builtin nadvice package in the output from `list-packages'.
>
> Hmm... it does for me: `src/emacs -Q` followed by `M-x list-packages`
> followed by `C-s nadvice C-s C-s` puts me on the line:
>
> nadvice 1.0 built-in Light-weight advice primitives for Elisp functions
>
>> To test each patch I deleted lisp/finder-inf.el before rebuilding.
>> Let me know if this is insufficient for a correct rebuild.
>
> Hmm... maybe finder-inf.el was rebuilt before finder.el was recompiled
> and it used a stale finder.elc?
> Could you double check?
After a full bootstrap, your patch does work.
AndyM
next prev parent reply other threads:[~2019-07-06 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 17:54 nadvice compatibility in package list Andy Moreton
2019-07-04 21:44 ` Thomas Fitzsimmons
2019-07-05 21:03 ` Stefan Monnier
2019-07-06 14:35 ` Andy Moreton
2019-07-06 16:39 ` Stefan Monnier
2019-07-06 18:15 ` Andy Moreton [this message]
2019-07-07 13:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h87z2fnr.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).