From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: policy discussion on bundling ELPA packages in the emacs tarball Date: Sat, 23 Jan 2021 01:27:15 -0800 Message-ID: <86h7n880lo.fsf@stephe-leake.org> References: <86eeifawx8.fsf@stephe-leake.org> <87czxygdl9.fsf@russet.org.uk> <86tur88izp.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (windows-nt) Cc: emacs-devel To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 10:27:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3FD1-0001FL-NH for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 10:27:55 +0100 Original-Received: from localhost ([::1]:45910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3FD0-0002VM-O6 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 04:27:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3FCV-00026g-5i for emacs-devel@gnu.org; Sat, 23 Jan 2021 04:27:23 -0500 Original-Received: from gateway36.websitewelcome.com ([192.185.193.12]:40678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3FCT-0002lS-8i for emacs-devel@gnu.org; Sat, 23 Jan 2021 04:27:22 -0500 Original-Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 685DC400CA8AF for ; Sat, 23 Jan 2021 03:27:19 -0600 (CST) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with SMTP id 3FCRlrNZ4SrGM3FCRlcDot; Sat, 23 Jan 2021 03:27:19 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+hxIpzUJwLW8OiTP+xLNRDhcV1NgzXpRtHwYRGK39qM=; b=D0LpsYgZZ72JqZfnxZjK25bbU B7nZ1dBkf2lKSAzWD90mX/utEfi80rhUGuLuta/5gq/BhZIcVasPg4pn6JcfBCgLknyDXgqHxgKax BMdjpSMxXnbmfbw0eTpACbHjq7E5SgnZd4mh8ZX7dDbRKfs6E+Mcn41DffNwUPSzWIWIAurVWMdlh bShEuOqCT7tV72UlhTj+P5we9/um6zdGMgYO7M+V9clFiaIqqgCyyE7Vs+eawkYiWOC07lj2FeOkM jWp8IXRyI/q9sP2ID1mTUmGCvkbb5N3lu4gsW0NSUEPUF0DL+GcF+gycFCx0bl3u2KwJR8ipYO5jJ o6vDiiu5w==; Original-Received: from [76.77.182.20] (port=49177 helo=Takver4) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l3FCQ-002ajX-Qg; Sat, 23 Jan 2021 02:27:18 -0700 In-Reply-To: <86tur88izp.fsf@stephe-leake.org> (Stephen Leake's message of "Fri, 22 Jan 2021 18:50:02 -0800") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1l3FCQ-002ajX-Qg X-Source-Sender: (Takver4) [76.77.182.20]:49177 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 2 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: neutral client-ip=192.185.193.12; envelope-from=stephen_leake@stephe-leake.org; helo=gateway36.websitewelcome.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263299 Archived-At: Stephen Leake writes: > I'll have to test some stuff. If the submodules cannot be worktrees, > then I think we have to abandon this approach. Although maybe using > --depth=1 (or some small number) would be acceptable. I've played with 'git submodules' on Windows mingw64. You can pass a local ELPA repository to 'git submodules add', but it copies the whole thing into the emacs repository: $git submodule add /c/Projects/elpa/.git packages/ada-mode Cloning into '/c/Projects/emacs/feature/core-elpa-by-copy/elpa/packages/ada-mode'... done. (I should have left out the 'packages/') The copied repostory is in /c/Projects/emacs/master/.git/worktrees/core-elpa-by-copy/modules/elpa/packages/ada-mode and is 237 MB (all of ELPA). There is not a way to specify the branch in the 'git submodule add' command, but we can do a 'git checkout external/packages/ada-mode' in the submodule root to get the right files. However, this will copy all of elpa.git for _each_ bundled package; clearly not acceptable. An alternative is to use worktrees from a local elpa.git. This is what ELPA does now for packages/*. There is elisp code to manage the worktrees in elpa/admin/elpa-admin.el - see elpaa--worktree-sync for example. We could reuse that code; we just have to add an arg for the root directory name (emacs/elpa instead of elpa/packages). With worktrees, we don't have git commands that operate on all the bundled packages at once, as 'git submodules ...' does. However, we'll be using an emacs front-end for edit/push/pull anyway. We may want to customize our favorite front-end to do them all at once; at least report changes in those directories so we know to visit them. At the very least, we'll want a shell script that runs 'git status' in each bundled package. -- -- Stephe