From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Completions and history Date: Tue, 12 Apr 2022 20:12:02 +0300 Organization: LINKOV.NET Message-ID: <86h76ytee5.fsf@mail.linkov.net> References: <20220411112901.kv3lsyvx6yxwjbph.ref@Ergus> <20220411112901.kv3lsyvx6yxwjbph@Ergus> <86sfqjzhgl.fsf@mail.linkov.net> <20220411174031.2yuh2je5fl3lej7i@Ergus> <86v8vetgst.fsf@mail.linkov.net> <20220412165958.2jzxtqxvx7jxmndy@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 19:18:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neKA7-0003EM-Ms for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 19:18:43 +0200 Original-Received: from localhost ([::1]:33390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neKA6-0001Ja-Br for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 13:18:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neK8e-00009w-Rp for emacs-devel@gnu.org; Tue, 12 Apr 2022 13:17:15 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:53843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neK8c-00064v-Qu for emacs-devel@gnu.org; Tue, 12 Apr 2022 13:17:12 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E3C58200004; Tue, 12 Apr 2022 17:17:06 +0000 (UTC) In-Reply-To: <20220412165958.2jzxtqxvx7jxmndy@Ergus> (Ergus's message of "Tue, 12 Apr 2022 18:59:58 +0200") Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288319 Archived-At: >> One problem is that completions are sorted alphabetically that >> makes no sense for history items which are sorted chronologically. >> So the first thing to do would be to add sorting keys in Completions >> that will allow switching the order between alphabetical and unsorted >> (history items are in chronological order, so unsorted should keep it) >> that will change the value of 'completions-sort'. > > A comment about this... completion-at-point-functions accept a list with > a format (START END COLLECTION . PROPS) > > The PROPS can be any :completion-extra-properties plus predicate and > exclusive.. maybe the way to do this is to add a property :sort or > similar... Then on the other side we use that property to select the > sorting method... Does it makes sense? It already works fine with: ``` (defun minibuffer-complete-history () "Complete the minibuffer history as far as possible. Like `minibuffer-complete' but completes on the history items instead of the default completion table." (interactive) (let ((completions-sort nil)) (completion-in-region (minibuffer--completion-prompt-end) (point-max) (symbol-value minibuffer-history-variable) nil))) (define-key minibuffer-local-map [C-tab] 'minibuffer-complete-history) ``` So the only question is whether this should have a new defcustom? Maybe 'minibuffer-complete-history-sort'? >> Another question: should duplicate history items be retained >> in the Completions window when history-delete-duplicates is nil? > > In principle yes... unless you add another custom for that... But the > first is the important part.. to have the history list in order... Another defcustom? Maybe 'minibuffer-complete-history-delete-duplicates'?