From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Tue, 25 Apr 2023 19:51:31 +0300 Organization: LINKOV.NET Message-ID: <86h6t3rjl8.fsf@mail.linkov.net> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> <838regwcnt.fsf@gnu.org> <87fs8o9spe.fsf@gmail.com> <835y9kw5ix.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40143"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 25 18:53:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prLvJ-000AIr-8N for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Apr 2023 18:53:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prLuP-00008S-AR; Tue, 25 Apr 2023 12:52:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prLuN-00007t-ML for emacs-devel@gnu.org; Tue, 25 Apr 2023 12:52:51 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prLuL-0003aI-CX; Tue, 25 Apr 2023 12:52:51 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C65BF1BF206; Tue, 25 Apr 2023 16:52:42 +0000 (UTC) In-Reply-To: <835y9kw5ix.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Apr 2023 14:44:06 +0300") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305663 Archived-At: >> >> This code and the defcustom is new in emacs-29, so we can still change >> >> it to be a predicate instead. At least we should document is better >> >> Eli> Agreed. Patches welcome. >> >> I assumed you were agreeing to the code change, which looks like this: > > No objections, unless some code is already using this with a function > that doesn't return a boolean. > > Matthias, Juri: any objections or comments? I guess the decision was delegated to the users because there is a choice what to do with the outline. Beside 'outline-hide-entry', there is also 'outline-show-branches' used by 'subtree-is-long' and 'subtree-has-long-lines'. So I see no reason to remove 'custom-function'. What could be done instead is to add a new choice 'custom-predicate'.