From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Fri, 14 Jun 2024 09:10:40 +0300 Organization: LINKOV.NET Message-ID: <86h6dwf40q.fsf@mail.linkov.net> References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20615"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 14 08:17:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sI0FU-0005DO-UI for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Jun 2024 08:17:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sI0Ef-0002Aq-GL; Fri, 14 Jun 2024 02:16:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI0Ee-00029L-0z for emacs-devel@gnu.org; Fri, 14 Jun 2024 02:16:28 -0400 Original-Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sI0Eb-0001lT-QL for emacs-devel@gnu.org; Fri, 14 Jun 2024 02:16:27 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5053CFF807; Fri, 14 Jun 2024 06:16:19 +0000 (UTC) In-Reply-To: (Eshel Yaron's message of "Thu, 13 Jun 2024 10:20:50 +0200") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320049 Archived-At: > Something like the following should fix this issue: > [...] > @@ -3816,7 +3816,9 @@ completion-basic-all-completions > 'point > (substring afterpoint 0 (cdr bounds))))) > (all (completion-pcm--all-completions prefix pattern table pred))) > - (completion-pcm--hilit-commonality pattern all))) > + (when all > + (nconc (completion-pcm--hilit-commonality pattern all) > + (car bounds))))) This fixes file name completion, but at the cost of breaking icomplete-mode: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) >(19 nil) (if (> (length string) pos) (add-face-text-property pos (1+ pos) 'completions-first-difference nil string)) (let* ((md (and regexp (string-match regexp string) (cdr (cdr (match-data t))))) ...) completion--hilit-from-re("it-window-to-buffer" "\\`f\\(.*?\\)" 1) completion-lazy-hilit("it-window-to-buffer") icomplete-completions("f" ...) icomplete-exhibit() completing-read-default("M-x " ...) read-extended-command-1("M-x " nil) read-extended-command() command-execute(execute-extended-command)