From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS make-thread Date: Sun, 23 Jun 2024 16:19:30 +0300 Message-ID: <86h6djeqzh.fsf@gnu.org> References: <87v823xvq1.fsf@localhost> <87zfre1p3r.fsf@gmail.com> <87zfreo5u6.fsf@localhost> <87plsa1n8k.fsf@gmail.com> <87wmmio3vq.fsf@localhost> <87jzii1hbs.fsf_-_@gmail.com> <8734p61evv.fsf@gmail.com> <87cyoa3w5d.fsf@localhost> <87le2whkt2.fsf@localhost> <86sex4g53k.fsf@gnu.org> <864j9kfbm0.fsf@gnu.org> <86zfrcdoqt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13149"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, eller.helmut@gmail.com, emacs-devel@gnu.org To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 23 15:20:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLN8t-0003D5-N3 for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Jun 2024 15:20:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLN86-0007Wd-7r; Sun, 23 Jun 2024 09:19:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLN84-0007WD-5X for emacs-devel@gnu.org; Sun, 23 Jun 2024 09:19:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLN83-000240-1d; Sun, 23 Jun 2024 09:19:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZW6cKdjFXbWbeXjaJUrP9ikVF/8/pQ6Uyn7q1zQ7x3s=; b=jKZfkWYw1TMhSA0sVs5X MMsV4I6woG3AdA+K88EP3O/WLSoZN75t/JAvur8vnhAIrxxNvrRx5sw7Tz3gMh5h4PrCjAXYtOCOa Yj/nqx2ylJHo8ENZyf29kd7x9iaqcYKrngO21JjhiwCatA8FCRI06QGZnV+UwzZb+tRDG/0fBQrJ8 /yvNnbsVB+0o4kqBHbOZUoExNVd6MZjmCrBWDLT/wbcIeGLoXlMudnBGpV07CxoZ71cpVJ09ifXpv 36WfmSyZkoNeeWBCgvK0MgEGoY/AkDYxjTML627yA1MUM2KtJEFG1noJtOS0qCEZ+u0lCcXr5khmX 7pPu+61EPsezPw==; In-Reply-To: (message from Gerd =?utf-8?Q?M=C3=B6llmann?= on Sun, 23 Jun 2024 12:27:42 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320519 Archived-At: > From: Gerd Möllmann > Cc: yantar92@posteo.net, eller.helmut@gmail.com, emacs-devel@gnu.org > Date: Sun, 23 Jun 2024 12:27:42 +0200 > > Gerd Möllmann writes: > > > Gerd Möllmann writes: > > > >> Eli Zaretskii writes: > >> > >>>> igc_collect calls mps_arena_collect which acquires the MPS lock, does a > >>>> full collection, and leaves the arena in parked state, so that the > >>>> caller has to mps_release it itself, which we do in igc_collect. This is > >>>> explicitly only intended for debugging purposes. It is thread-safe. > >>> > >>> Then why did we get the MPS assertion about warm and cold in this case? > >> > >> I don't know, but I think the real error happens before that. The > >> backtrace from my debug version shows that something is wrong with the > >> mps_thr_t that it is using. > > > > FYI, I think I have it. Pushing later. > > That went better than I expected... Pushed, please let me know if it > works for you. Thanks, seems to work fine now.