From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Kanis Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] trivial patch, jumping cursor in term Date: Fri, 25 Sep 2009 10:56:18 +0200 Message-ID: <86fxabcsi5.fsf@kanis.fr> References: <86d45hhia4.fsf@kanis.fr> <868wg4demq.fsf@kanis.fr> <200909241711.n8OHBIKh010274@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253869213 27835 80.91.229.12 (25 Sep 2009 09:00:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Sep 2009 09:00:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu , Stefan Monnier , Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 25 11:00:05 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mr6er-0004q7-1a for ged-emacs-devel@m.gmane.org; Fri, 25 Sep 2009 11:00:05 +0200 Original-Received: from localhost ([127.0.0.1]:40829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr6eq-00054g-2R for ged-emacs-devel@m.gmane.org; Fri, 25 Sep 2009 05:00:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mr6bq-0002zB-UD for emacs-devel@gnu.org; Fri, 25 Sep 2009 04:56:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mr6bp-0002yf-Pd for emacs-devel@gnu.org; Fri, 25 Sep 2009 04:56:58 -0400 Original-Received: from [199.232.76.173] (port=60481 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr6bp-0002yc-JP for emacs-devel@gnu.org; Fri, 25 Sep 2009 04:56:57 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:35471) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mr6bp-0000wM-6V for emacs-devel@gnu.org; Fri, 25 Sep 2009 04:56:57 -0400 Original-Received: from kanis.fr ([75.127.73.245]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mr6be-0007f0-EY for emacs-devel@gnu.org; Fri, 25 Sep 2009 04:56:46 -0400 Original-Received: from [89.83.137.164] (helo=tao) by kanis.fr with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Mr6bX-0007lL-8O; Fri, 25 Sep 2009 04:56:39 -0400 In-Reply-To: <200909241711.n8OHBIKh010274@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 24 Sep 2009 10:11:18 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Fri, 25 Sep 2009 04:59:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115605 Archived-At: Hi Dan, Stefan, Stefan Monnier wrote: > Hmm... it should have *exactly* the same effect as your patch. Does it work for you? It didn't seem to work for me... Dan Nicolaescu wrote: > After your changes yesterday an error is thrown when using the above scenario: > error in process filter: Wrong type argument: number-or-marker-p, nil Yeah I've seen it too, the following trivial patch fixes it. --- a/lisp/misc/term.el Thu Sep 24 12:01:01 2009 +0200 +++ b/lisp/misc/term.el Fri Sep 25 10:53:21 2009 +0200 @@ -3730,7 +3730,7 @@ (let ((start-column (term-horizontal-column))) (when (and check-for-scroll (or term-scroll-with-delete term-pager-count)) (setq down (term-handle-scroll down))) - (unless (and (= term-current-row 0) (< down 0)) + (unless (and term-current-row (= term-current-row 0) (< down 0)) (term-adjust-current-row-cache down) (when (or (/= (point) (point-max)) (< down 0)) (setq down (- down (term-vertical-motion down))))) Take care, -- Ivan Kanis http://kanis.fr The cause of these complaints lies in WinZip, which turns an all upper-case directory into an all lower case one in a fit of helpfulness -- Ant Documentation