From: Ivan Kanis <expire-by-2009-09-30@kanis.fr>
To: Dan Nicolaescu <dann@ics.uci.edu>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] trivial patch, jumping cursor in term
Date: Fri, 25 Sep 2009 10:56:18 +0200 [thread overview]
Message-ID: <86fxabcsi5.fsf@kanis.fr> (raw)
In-Reply-To: <200909241711.n8OHBIKh010274@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Thu, 24 Sep 2009 10:11:18 -0700 (PDT)")
Hi Dan, Stefan,
Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Hmm... it should have *exactly* the same effect as your patch.
Does it work for you? It didn't seem to work for me...
Dan Nicolaescu <dann@ics.uci.edu> wrote:
> After your changes yesterday an error is thrown when using the above scenario:
> error in process filter: Wrong type argument: number-or-marker-p, nil
Yeah I've seen it too, the following trivial patch fixes it.
--- a/lisp/misc/term.el Thu Sep 24 12:01:01 2009 +0200
+++ b/lisp/misc/term.el Fri Sep 25 10:53:21 2009 +0200
@@ -3730,7 +3730,7 @@
(let ((start-column (term-horizontal-column)))
(when (and check-for-scroll (or term-scroll-with-delete term-pager-count))
(setq down (term-handle-scroll down)))
- (unless (and (= term-current-row 0) (< down 0))
+ (unless (and term-current-row (= term-current-row 0) (< down 0))
(term-adjust-current-row-cache down)
(when (or (/= (point) (point-max)) (< down 0))
(setq down (- down (term-vertical-motion down)))))
Take care,
--
Ivan
Kanis http://kanis.fr
The cause of these complaints lies in WinZip, which turns an all
upper-case directory into an all lower case one in a fit of
helpfulness
-- Ant Documentation
next prev parent reply other threads:[~2009-09-25 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 14:01 [PATCH] trivial patch, jumping cursor in term Ivan Kanis
2009-09-24 1:41 ` Dan Nicolaescu
2009-09-24 2:15 ` Stefan Monnier
2009-09-24 6:46 ` Ivan Kanis
2009-09-24 15:02 ` Stefan Monnier
2009-09-24 17:11 ` Dan Nicolaescu
2009-09-25 8:56 ` Ivan Kanis [this message]
2009-09-25 14:29 ` Stefan Monnier
2009-09-28 6:30 ` Ivan Kanis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fxabcsi5.fsf@kanis.fr \
--to=expire-by-2009-09-30@kanis.fr \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).