From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0382fd4: xref-find-definitions: Exclude more generic function items. Date: Thu, 13 Aug 2015 23:33:56 -0500 Message-ID: <86fv3mv68b.fsf@stephe-leake.org> References: <20150813182108.2057.52629@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439526891 19370 80.91.229.3 (14 Aug 2015 04:34:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 14 Aug 2015 04:34:51 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 14 06:34:35 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZQ6hM-0000e6-Vh for ged-emacs-devel@m.gmane.org; Fri, 14 Aug 2015 06:34:33 +0200 Original-Received: from localhost ([::1]:44823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQ6hH-00050B-5k for ged-emacs-devel@m.gmane.org; Fri, 14 Aug 2015 00:34:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQ6h4-000506-L1 for emacs-devel@gnu.org; Fri, 14 Aug 2015 00:34:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQ6h1-0001Cf-7J for emacs-devel@gnu.org; Fri, 14 Aug 2015 00:34:14 -0400 Original-Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:49783) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZQ6h1-0001Bx-0S for emacs-devel@gnu.org; Fri, 14 Aug 2015 00:34:11 -0400 Original-Received: (qmail 9494 invoked by uid 0); 14 Aug 2015 04:34:07 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy4.mail.unifiedlayer.com with SMTP; 14 Aug 2015 04:34:07 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw2 with id 4Ua21r00h2UdiVW01Ua5hV; Thu, 13 Aug 2015 22:34:05 -0600 X-Authority-Analysis: v=2.1 cv=RZcDVTdv c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=y7kgw_RnJtkA:10 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=uRRa74qj2VoA:10 a=N84Br52HWDtJjm5n2iEA:9 Original-Received: from [76.218.37.33] (port=54222 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZQ6gu-0004jB-EL for emacs-devel@gnu.org; Thu, 13 Aug 2015 22:34:04 -0600 In-Reply-To: (Stefan Monnier's message of "Thu, 13 Aug 2015 17:14:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 69.89.23.142 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188789 Archived-At: Stefan Monnier writes: >> +(defcustom find-feature-regexp >> + (concat ";;; Code:") > > FWIW, I think this is overkill and marginally incorrect. > (require 'foo) is Elisp's way to "include" a file, so xref should just > jump to this file's buffer rather than to a specific location within > that file. Just like ffap does in a #include. Yes, compatibility with ffap makes sense. If the file is already in a buffer, it goes to the current point in that buffer. Otherwise it goes to point-min. That requires a change in xref--pop-to-location; it insists on going to a marker. We'll have to introduce some flag value that means "preserve current point". Or have the code that produces that marker set it at the current point. Short of that, just going to point-min is probably best. -- -- Stephe