From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Tue, 19 Mar 2024 14:26:40 +0200 Message-ID: <86frwm4dbz.fsf@gnu.org> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <86sf0n4sfq.fsf@gnu.org> <87r0g79mh1.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21107"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, stefankangas@gmail.com, jonas@bernoul.li To: Jeremy Bryant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 13:27:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmYZ2-0005G0-Hm for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 13:27:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmYYK-0001Oc-Ls; Tue, 19 Mar 2024 08:26:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmYYI-0001Mn-GD for emacs-devel@gnu.org; Tue, 19 Mar 2024 08:26:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmYYF-0006PQ-UR; Tue, 19 Mar 2024 08:26:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RHD1s6LCCGpvnMLNTvAGC+LxK9MBQTwkBy9WN4V2Grs=; b=ECX9zFjJRcJv 03DN+yI58EZzKKR1EVnNOezOCyEtID5rpylvz8/dgdKOQJQ4g8itb3yi3D4GV07N4U/cRlVs96J1l m/1Nh0XI7S0nkyZHLWtwTyGmbp9I4a46esx7AciA8zSYPLhOaFGjoHiUaenG+OPh5DWEpO+iSY4N6 MVfWK86DWc1kcgwGsMm7jNANeKK8Fieo8kKS4r6dxMiPplRHb/dSnefd2i+og0yL3qWRQRatbcnk1 /KUuplcnAqBDnOYFSrnPhK5Y5T190AgsMdHIovkRa4CHJavyKUz6lCvq/PXZQ8qgvBMEyZt88rtDk ORJhy+IBeTcpp6opGp+hlA==; In-Reply-To: <87r0g79mh1.fsf@jeremybryant.net> (message from Jeremy Bryant on Mon, 18 Mar 2024 22:58:02 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317187 Archived-At: > From: Jeremy Bryant > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, > stefankangas@gmail.com, jonas@bernoul.li > Date: Mon, 18 Mar 2024 22:58:02 +0000 > > > Eli Zaretskii writes: > > >> From: Jeremy Bryant > >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org, j.j.oddie@gmail.com, > >> stefan@marxist.se, stefankangas@gmail.com, jonas@bernoul.li > >> Date: Sun, 17 Mar 2024 21:48:08 +0000 > >> > >> Manual? > >> Should the documentation for macrostep be included in the Emacs Lisp > >> manual section Macros? > > > > Yes, I think so. > > > > Please also provide a suitable entry for NEWS. > > > >> Code? > >> The main file is attached for convenience, from the orphanage upstream > >> (https://github.com/emacsorphanage/macrostep). > >> Are any changes needed before this is merged into Emacs? > >> I volunteer to write some code towards this, please let me know. > > > > Please add :version tags to all the defcustom's and defface's. > > > >> (define-obsolete-variable-alias 'macrostep-mode-keymap > >> 'macrostep-mode-map "2023") > >> (define-obsolete-variable-alias 'macrostep-keymap 'macrostep-mode-map "2022") > > > > The years there should be changed to Emacs versions, I think. > > > >> (defvar macrostep-mode-map > >> (let ((map (make-sparse-keymap))) > >> (define-key map (kbd "RET") #'macrostep-expand) > >> (define-key map "=" #'macrostep-expand) > >> (define-key map "e" #'macrostep-expand) > > > > Bonus points for converting this into defvar-keymap. > > > >> ;; Local Variables: > >> ;; indent-tabs-mode: nil > >> ;; End: > > > > I think this should be deleted, as this is now the default in ELisp > > buffers. > > OK, I'll start working on these. Thanks. > For the macrostep commits, is it easier for future integration that this > is done externally and submitted in one go, or would something like a > new macrostep branch in the Emacs tree be more appropriate? A branch is preferable if you want people to be able to use and test the package before it lands. If this package is already in use by enough people, so you can be reasonably sure it doesn't have any grave problems, a branch is not required, and you can submit everything as a single patch.