From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Sat, 24 Aug 2024 11:42:09 +0300 Message-ID: <86frqunwgu.fsf@gnu.org> References: <86jzgg5pgv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= , Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 24 10:42:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shmME-00070O-N4 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Aug 2024 10:42:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shmLg-00071W-4M; Sat, 24 Aug 2024 04:42:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shmLe-00071G-AY for emacs-devel@gnu.org; Sat, 24 Aug 2024 04:42:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shmLe-0008UP-0a; Sat, 24 Aug 2024 04:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=pxxUrYyQ/dDjQfy4Ih562L0uXJYMXqtDtVz82ED59MQ=; b=pTobg36wyF07ZAdG0MVp 3pkzildvPR2lBxPqCQRNDnIVmZzf6XllX36cJmr3crgPg+v8pdZVIWzoLfzg523sB2263gRDICahO kywgKIxypM+68W7LYeMyBuqfU2cviDB/JL+DkjAn3N+uXE/7o0C5/OkMGIg7zMh3FMH11A2WofhYW k13t0PVoXYumX0nwCzV9Jw9g6PieY40l3sjSMSmWPmq/PQqtQjAnqmRdYTs/4yCVyco7R6LVXRVF/ oGXuj5WGEwETPaz7O7syDcPYlDwWKnwD8mxCA4E4MDM3r7aU++SNfWtjD4JL17LSGBMbqnESQeSOk CcAlOasDEH0rqw==; In-Reply-To: (message from =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= on Sat, 17 Aug 2024 08:35:36 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323107 Archived-At: > From: Sebastián Monía > Cc: emacs-devel@gnu.org > Date: Sat, 17 Aug 2024 08:35:36 -0400 > > Sebastián Monía writes: > > --- > This smaller patch does only the eww buffer list portion, and we leave > EWW buffer reloads as they are now. > > lisp/net/eww.el | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > index b2e1c5a72e5..660731faa30 100644 > --- a/lisp/net/eww.el > +++ b/lisp/net/eww.el > @@ -2601,8 +2601,10 @@ see)." > > ;;; eww buffers list > > -(defun eww-list-buffers () > - "Enlist eww buffers." > +(defun eww-list-buffers (&optional _ignore-auto _noconfirm) > + "Pop a buffer with a list of eww buffers. > +Optional arguments make this function compatible with the > +`revert-buffer-function' interface." > (interactive) > (let (buffers-info > (current (current-buffer))) > @@ -2719,6 +2721,7 @@ see)." > \\{eww-buffers-mode-map}" > :interactive nil > (buffer-disable-undo) > + (setq-local revert-buffer-function #'eww-list-buffers) > (setq truncate-lines t)) > > ;;; Desktop support > -- > 2.45.2.windows.1 Jim, would you please review this and provide comments, if any? Thanks.