From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Wed, 12 Nov 2008 15:42:30 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86ej1gfwop.fsf@lifelogs.com> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> <86od0mgcz5.fsf@lifelogs.com> <200811120111.mAC1B6h1005596@mothra.ics.uci.edu> <86tzacg8yc.fsf@lifelogs.com> <200811121956.mACJugiW007492@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226527046 4035 80.91.229.12 (12 Nov 2008 21:57:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Nov 2008 21:57:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 12 22:58:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0NjH-0008Ui-E7 for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 22:58:27 +0100 Original-Received: from localhost ([127.0.0.1]:58110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0Ni9-00041e-Cx for ged-emacs-devel@m.gmane.org; Wed, 12 Nov 2008 16:57:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0NUG-000740-Ag for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:42:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0NUC-00073W-M6 for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:42:54 -0500 Original-Received: from [199.232.76.173] (port=34478 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0NUC-00073T-C7 for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:42:52 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:59775 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L0NUB-0000R2-TC for emacs-devel@gnu.org; Wed, 12 Nov 2008 16:42:52 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L0NU4-00080f-Ig for emacs-devel@gnu.org; Wed, 12 Nov 2008 21:42:44 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 21:42:44 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Nov 2008 21:42:44 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 49 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:gm1ZM4cW87yZBKZ6gyeURiKjsVM= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105618 Archived-At: On Wed, 12 Nov 2008 11:56:42 -0800 (PST) Dan Nicolaescu wrote: DN> Ted Zlatanov writes: >> On Tue, 11 Nov 2008 17:11:06 -0800 (PST) Dan Nicolaescu wrote: >> DN> If you are interested in improving this area, please also look at one of DN> the TODO items in vc.el: >> DN> ;; - When vc-next-action calls vc-checkin it could pre-fill the DN> ;; *VC-log* buffer with some obvious items: the list of files that DN> ;; were added, the list of files that were removed. If the diff is DN> ;; available, maybe it could even call something like DN> ;; `diff-add-change-log-entries-other-window' to create a detailed DN> ;; skeleton for the log... DN> ;; >> >> I think that should be up to the user, to be done in the hook. DN> Sure, but it would be nice to provide a way to do it by default. I think we agree that something is good, but it will be hard to agree on the particulars of what to put in the buffer. So maybe the answer is a format-like string (falling back to a function call) that the user can customize? >> The information, diff and files added/removed/affected, exists >> outside the commit message so putting it inside the message >> duplicates the information. DN> It exists, but it means you have to look in two places for it, it is DN> customary to put such information in the logs. Sorry, I don't see what you mean. Putting it in the logs would ensure you have two places to look, and when it's inaccurate it would be an even worse situation. DN> Also you only addressed one part of that TODO entry, the whole point is DN> to make it easier to write log entries, and provide as much as possible DN> by default. The two goals diverge significantly once the threshold of "enough" information is passed, and unfortunately that is a different point for every user. Specifically regarding the detailed skeleton, I think we're getting to the format string/function concept I mentioned above. I don't think Emacs has a default way to do this, but skeleton.el should work. Ted