From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Use variable-pitch face in more places Date: Wed, 24 Nov 2021 11:12:13 +0200 Organization: LINKOV.NET Message-ID: <86ee75x6he.fsf@mail.linkov.net> References: <87bl2hyzca.fsf@gnus.org> <8735nszpdv.fsf@gnus.org> <87sfvswrp8.fsf@gnus.org> <86mtlw85ro.fsf@mail.linkov.net> <87h7c3fb4t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Stefan Kangas , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 24 10:19:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpoQp-0001aW-SF for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Nov 2021 10:19:11 +0100 Original-Received: from localhost ([::1]:58488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpoQo-0004DV-P7 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Nov 2021 04:19:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpoOi-0002N7-Vs for emacs-devel@gnu.org; Wed, 24 Nov 2021 04:17:00 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpoOf-0002sy-MK for emacs-devel@gnu.org; Wed, 24 Nov 2021 04:17:00 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 79742E0007; Wed, 24 Nov 2021 09:16:47 +0000 (UTC) In-Reply-To: <87h7c3fb4t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 23 Nov 2021 10:56:50 +0100") Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279987 Archived-At: >> Thanks for noticing this. Fixed patch attached, as well as a new screenshot. > > I think that looks really nice. I tried really hard, but can't see variable-pitch on the header line 🤓 And indeed, my suggestion to use add-face-text-property was wrong, sorry. The correct function name can be found in these commented out lines in Info-breadcrumbs: ;; (font-lock-append-text-property 0 (length line) ;; 'font-lock-face 'header-line line) Only then the header-line shows variable-pitch on the header line: diff --git a/lisp/info.el b/lisp/info.el index cd4c867f4e..43be21c570 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -4822,6 +4822,8 @@ Info-fontify-node (concat "No next, prev or up links -- " (buffer-substring (point) header-end)) (buffer-substring (point) header-end))))) + (font-lock-append-text-property + 0 (length header) 'font-lock-face 'variable-pitch header) (put-text-property (point-min) (1+ (point-min)) 'header-line (replace-regexp-in-string --