unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Ergus <spacibba@aol.com>
Cc: Po Lu <luangruo@yahoo.com>, Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Question about completion behavior
Date: Thu, 10 Mar 2022 20:50:43 +0200	[thread overview]
Message-ID: <86ee39r69o.fsf@mail.linkov.net> (raw)
In-Reply-To: <20220310140331.xa53sex6wywkr56l@Ergus> (Ergus's message of "Thu,  10 Mar 2022 15:03:31 +0100")

> I just added a new branch feature/completions-customs.

Thank you.  I hope these small steps that add new options
will gradually place the default completion UI on a par with
modern completion packages.

One question - please explain what values of completion-auto-help
nil/t/lazy/visible/always now do in these cases that you posted earlier:

  1. no unique        (shows or update completions)
  2. unique common    (complete-common and UPDATE completions)
  3. unique candidate (complete and hides completion)
  4. unique common but completion is a valid entry (complete-common and hides completion)

> The changes there are minimal and finished in my opinion.  Whenever any
> of the maintainers decide they can correct, fix, or merge into
> master. (there is a small issue with the reference in the manual, so
> please fix it, but I don't have any more time)

I fixed these and some other issues in the branch.

> The changes include the max-height for completion window, a
> completions-highlight-mode and the new values for completion-auto-help.

Why not highlight the completions by default?  Unlike other changes,
highlighting doesn't change the previous behavior.

> I didn't include the zcomplete-mode because I am not sure how to name it
> and didn't receive any feedback except from Juri.  In total it is 53
> lines and provides an interaction similar to zsh (as explained before)
> which may be very suitable for new users.

I'm still unsure about this mode.  It's unclear what is the answer
to the main question: should it select the completion buffer or not?

I'll soon post a patch to allows navigation in the completion buffer
without selecting it, i.e. from the minibuffer.  This will handle
the problem of self-inserting keys that will continue working
in the minibuffer.  When this will prove to be insufficient,
then we could add new mode to auto-select the completions buffer.
But then why don't just use the recently added completion-auto-select?

> Apart from that I am wondering if it makes sense to add an option to
> propertise/configure the Initial line in the Completions buffer (there
> is one to remove the help, but not the other)

Do you mean completion-show-help whose nil doesn't remove
text "Possible completions are:"?

> (for example to remove it or add properties like intangible, a face etc)
> could we also add a sort of counter there to indicate the total number
> of candidates?

Good idea.



  reply	other threads:[~2022-03-10 18:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220309001013.gxyh2uasbuxiz6ww.ref@Ergus>
2022-03-09  0:10 ` Question about completion behavior Ergus
2022-03-09  0:22   ` Stefan Monnier
2022-03-09  1:46     ` Ergus
2022-03-09  3:05       ` Stefan Monnier
2022-03-09  3:37         ` Eli Zaretskii
2022-03-09 10:11           ` Ergus
2022-03-09 11:46             ` Ergus
2022-03-09 13:16               ` Eli Zaretskii
2022-03-09 13:46                 ` Po Lu
2022-03-09 17:32                   ` Stefan Monnier
2022-03-09 17:41                     ` Ergus
2022-03-10  0:42                     ` Po Lu
2022-03-10 10:21                       ` Ergus
2022-03-10 11:15                         ` Po Lu
2022-03-10 14:03                           ` Ergus
2022-03-10 18:50                             ` Juri Linkov [this message]
2022-03-10 22:35                               ` Ergus
2022-03-12 18:31                                 ` Juri Linkov
2022-03-13 14:58                                   ` Ergus
2022-03-12  0:17                               ` Ergus
2022-03-12 18:34                                 ` Juri Linkov
2022-03-13 11:21                                   ` Ergus
2022-03-13 17:44                                     ` Juri Linkov
2022-03-13 18:50                                       ` Ergus
2022-03-13 18:57                                         ` Eli Zaretskii
2022-03-13 19:49                                           ` Ergus
2022-03-13 20:48                                       ` [External] : " Drew Adams
2022-03-13 21:15                                         ` Ergus
2022-03-13 23:14                                           ` Drew Adams
2022-03-13 23:38                                             ` Ergus
2022-03-14  2:23                                               ` Drew Adams
2022-03-12 20:25                             ` Drew Adams
2022-03-09 14:30                 ` Ergus
2022-03-09 16:14                   ` [PATCH] " Ergus
2022-03-09 16:56                   ` Eli Zaretskii
2022-03-09 13:10             ` Eli Zaretskii
2022-03-09 14:22               ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ee39r69o.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).