From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Mon, 14 Mar 2022 10:41:56 +0200 Organization: LINKOV.NET Message-ID: <86ee357wob.fsf@mail.linkov.net> References: <86v8wlprc0.fsf@mail.linkov.net> <874k454n84.fsf@gnus.org> <86ilslmvql.fsf@mail.linkov.net> <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20249"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Ergus , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 14 09:49:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTgO7-00054u-9R for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 09:49:11 +0100 Original-Received: from localhost ([::1]:57650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTgO5-0006t8-T7 for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Mar 2022 04:49:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTgMe-0005mk-7K for emacs-devel@gnu.org; Mon, 14 Mar 2022 04:47:40 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:48701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTgMc-00011x-Bg for emacs-devel@gnu.org; Mon, 14 Mar 2022 04:47:39 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7FA321BF20D; Mon, 14 Mar 2022 08:47:33 +0000 (UTC) In-Reply-To: <87pmmquew4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Mar 2022 15:05:15 +0100") Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287116 Archived-At: >> `M-' in bug#49931 let-binds the new user option, >> so it could let-bind completions-highlight-mode as well. > > Yes. Alas, after the last commit c1ea52f4ad in the feature/completions-customs branch this is not possible anymore. Before this commit we were able to let-bind `cursor-face-highlight-mode' in the new command: ``` (defun minibuffer-previous-completion (&optional n) "Run `previous-completion' from the minibuffer in its completions window." (interactive "p") (with-minibuffer-completions-window (let ((cursor-face-highlight-mode t)) (previous-completion n)))) ``` because 'redisplay--update-cursor-face-highlight' was always presented in `pre-redisplay-functions', and the mode was checked with (when cursor-face-highlight-mode But now the hook is added only when mode is enabled.