From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Looking at function Date: Sun, 21 Aug 2022 19:09:27 +0300 Organization: LINKOV.NET Message-ID: <86edx9imi4.fsf@mail.linkov.net> References: <86edz8k6q1.fsf@mail.linkov.net> <86y1wzv4uv.fsf@mail.linkov.net> <3c642f4d-471b-d6d2-8519-b4707e1193ba@yandex.ru> <864jzm4u9f.fsf@mail.linkov.net> <875d1684-e3d7-a16c-7fee-b5a03e45edce@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 21 18:51:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPoAz-0001iY-A7 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 18:51:53 +0200 Original-Received: from localhost ([::1]:57710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPoAy-0000z6-93 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Aug 2022 12:51:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPo93-0006L3-4y for emacs-devel@gnu.org; Sun, 21 Aug 2022 12:49:53 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPo91-0004dh-Ap for emacs-devel@gnu.org; Sun, 21 Aug 2022 12:49:52 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 504A8C0005; Sun, 21 Aug 2022 16:49:47 +0000 (UTC) In-Reply-To: <875d1684-e3d7-a16c-7fee-b5a03e45edce@yandex.ru> (Dmitry Gutov's message of "Wed, 17 Aug 2022 03:27:48 +0300") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293747 Archived-At: >>>>> If so, perhaps a good alternative is to stop caring about whether those >>>>> matches are adjacent and always store the latest two matches, whether they >>>>> are next to each other or not. >> And this is how it's implemented by the patches in bug#14013 and >> bug#53758. > > Sounds good, then. So this is a workable solution? > > Or have you come across some pitfalls? Everything works fine, but might require adding more conditionals like '(>= emacs-major-version 29)' in 'xref--query-replace-1' as suggested at the end of bug#54733.