unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Po Lu <luangruo@yahoo.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>,  emacs-devel@gnu.org
Subject: Re: master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse
Date: Thu, 31 Aug 2023 09:37:12 +0300	[thread overview]
Message-ID: <86edjj7m5j.fsf@mail.linkov.net> (raw)
In-Reply-To: <8734zzudo7.fsf@yahoo.com> (Po Lu's message of "Thu, 31 Aug 2023 10:51:52 +0800")

> My point is this: xref-find-definitions itself, not its callers, should
> take EVENT, then call (goto-char (posn-point (event-start event)))
> within.

Alas, most of the commands don't support EVENT.  It's a real problem
for menu items at the bottom of the context menu where submenus are
constructed from major/minor modes.  For example, in emacs-lisp-mode
clicking on "Emacs-Lisp -> Indent Line" operates on the line where point
is located, not on the clicked line.  And the rest of commands do the same.

Maybe while constructing the context menu, some commands should be wrapped
with a new function that will use '(save-excursion (mouse-set-point event))'.
The problem is that this is necessary only for some of them, not all:
only for the commands that rely on the position of the mouse click,
not for the commands that operate on the whole buffer.  For example,
in emacs-lisp-mode only for the menu item "Evaluate Last S-expression",
but not for "Evaluate Buffer".



  reply	other threads:[~2023-08-31  6:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <169344150641.11482.13012085201452768898@vcs2.savannah.gnu.org>
     [not found] ` <20230831002506.C0C6DC038B5@vcs2.savannah.gnu.org>
2023-08-31  0:43   ` master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse Po Lu
2023-08-31  0:54     ` Dmitry Gutov
2023-08-31  1:10       ` Po Lu
2023-08-31  2:05         ` Dmitry Gutov
2023-08-31  2:51           ` Po Lu
2023-08-31  6:37             ` Juri Linkov [this message]
2023-09-01  0:59               ` Po Lu
2023-09-01  6:50                 ` Juri Linkov
2023-09-03 17:34                   ` Juri Linkov
2023-09-04 16:42                     ` Juri Linkov
2023-08-31 11:03             ` Dmitry Gutov
2023-08-31 11:35               ` Po Lu
2023-08-31 16:38               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86edjj7m5j.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=dmitry@gutov.dev \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).