Re: [PATCH] Support for Sqlite Archive files

[Eli Zaretskii <eliz@gnu.org>]

> From: Vladimir Kazanov <vekazanov@gmail.com>
> Date: Fri, 21 Jun 2024 12:12:05 +0100
> 
> Sqlite Archive files are a format similar to archive but using Sqlite
> database as an underlying format. See https://sqlite.org/sqlar.html
> for details.
> 
> Included is a patch for archive-mode  that adds a backend utilising
> the sqlite3 cli utility for inspecting and editing sqlar files. The
> code includes a set of unit tests as well as an example sqlar file.

Thanks, but why do we need a cli utility when we have built-in SQLite
support?  Can't we access the SQLite Archive files via that built-in
support?  I'd prefer to have that instead of relying on external
utility.

In any case, the code you posted should at least bind
coding-system-for-read and coding-system-for-write to utf-8 (and
perhaps also file-name-coding-system if necessary), since AFAIU SQLite
databases use UTF-8 encoding for text.  Suggest to try your code in a
non-UTF-8 locale to see if it works or not.

> +(defcustom archive-sqlar-write-file-member
> +  '("sqlite3" "-A" "--update" "--file")
> +  "Program and its options to run in order to delete Sqlite Archive
> +file members."

The doc string seems like a copy/paste mistake.

Also, the doc strings of these options should tell that -A must be in
the options, no?  Or maybe the option should only hold options to be
_added_ to the standard mandatory ones?

> +  :version "29.1"

The version should be 31.1, I think (as Emacs 30 will start its
release cycle very soon).